Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge. Just for research. #215

Closed
wants to merge 1 commit into from
Closed

Do not merge. Just for research. #215

wants to merge 1 commit into from

Conversation

ewjoachim
Copy link
Member

@ewjoachim ewjoachim commented Jul 25, 2023

The aim is to check that when an org owner approves the PR, the webhook contains "author_association": "OWNER"

It should be, according to the doc but it's somewhat unclear.

@github-actions
Copy link

End-to-end public repo
End-to-end private repo
If the tests fail, @ewjoachim will be added to the private repo

@github-actions
Copy link

Coverage report

The coverage rate went from 100% to 100% ➡️
The branch rate is 100%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

Copy link
Member

@kieferro kieferro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review

@ewjoachim
Copy link
Member Author

Dammit,

"author_association": "MEMBER",

@ewjoachim ewjoachim closed this Jul 26, 2023
@ewjoachim ewjoachim deleted the ewjoachim-patch-1 branch August 9, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants