Review comments

py-cov-action · Jul 27, 2023 · 9b8a0a0 · 9b8a0a0
1 parent 7e1c97b
commit 9b8a0a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/coverage_comment/subprocess.py b/coverage_comment/subprocess.py
@@ -65,4 +65,3 @@ def _git(self, *args: str, env: dict[str, str] | None = None, **kwargs) -> str:
 
     def __getattr__(self, name: str) -> Any:
         return functools.partial(self._git, name.replace("_", "-"))
-        return functools.partial(self._git, name.replace("_", "-"))
diff --git a/tests/unit/test_subprocess.py b/tests/unit/test_subprocess.py
@@ -6,20 +6,20 @@
 
 
 def test_run__ok():
-    assert subprocess.run("echo", "yay", path=".").strip() == "yay"
+    assert subprocess.run("echo", "yay", path=pathlib.Path(".")).strip() == "yay"
 
 
 def test_run__path():
-    assert subprocess.run("pwd", path="/").strip() == "/"
+    assert subprocess.run("pwd", path=pathlib.Path("/")).strip() == "/"
 
 
 def test_run__kwargs():
-    assert "A=B" in subprocess.run("env", env={"A": "B"}, path=".")
+    assert "A=B" in subprocess.run("env", env={"A": "B"}, path=pathlib.Path("."))
 
 
 def test_run__error():
     with pytest.raises(subprocess.SubProcessError):
-        subprocess.run("false", path=".")
+        subprocess.run("false", path=pathlib.Path("."))
 
 
 @pytest.fixture
@@ -85,4 +85,3 @@ def test_git__error(mocker):
 
     with pytest.raises(subprocess.GitError):
         git.add("some_file")
-        git.add("some_file")