-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Positioning dialog for iOS #72
Conversation
I just wanted to ask if there is any reason why this PR hasn't been merged yet? (Is there any problem with the positioning in some cases?) In my application, it seems to work fine. 😃 To me, it would be nice to use the up-to-date plugin directly from this repo... |
Can you roughly estimate, when you will have the time to merge this PR, @pwlin ? |
hi @VincentRoth, thank you for your contribution to this project. Apologies that no one responded to this PR. If you can get the merge conflicts resolved then I would be happy to merge this in and create a new release for it. All the best. |
hi @shnist, I have resolved conflicts. By reading the code it should work the same way but I have no more iOS devices or Mac to test the merge. |
hi @VincentRoth, thanks very much for taking the time to resolve the merge conflicts. The code looks fine to me. I'm going to merge it and do some testing and then will do a new release in the near future! |
I add a parameter for positioning the dialog for iOS
It is based on @bogdanconstantinescu pull request and on @pwlin comment