Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positioning dialog for iOS #72

Merged
merged 9 commits into from
Dec 12, 2018
Merged

Positioning dialog for iOS #72

merged 9 commits into from
Dec 12, 2018

Conversation

VincentRoth
Copy link
Contributor

I add a parameter for positioning the dialog for iOS

It is based on @bogdanconstantinescu pull request and on @pwlin comment

@earnaz earnaz mentioned this pull request Nov 18, 2016
@MBuchalik
Copy link

I just wanted to ask if there is any reason why this PR hasn't been merged yet? (Is there any problem with the positioning in some cases?) In my application, it seems to work fine. 😃 To me, it would be nice to use the up-to-date plugin directly from this repo...

@tobiaswaltl
Copy link

Can you roughly estimate, when you will have the time to merge this PR, @pwlin ?

@shnist
Copy link
Collaborator

shnist commented Dec 11, 2018

hi @VincentRoth, thank you for your contribution to this project. Apologies that no one responded to this PR. If you can get the merge conflicts resolved then I would be happy to merge this in and create a new release for it. All the best.

@VincentRoth
Copy link
Contributor Author

hi @shnist, I have resolved conflicts. By reading the code it should work the same way but I have no more iOS devices or Mac to test the merge.
Let me know if there is any issue with the PR but as the parameter is optional it should not modify existing call to open.

@shnist shnist mentioned this pull request Dec 12, 2018
@shnist shnist merged commit b969aa7 into pwlin:master Dec 12, 2018
@shnist
Copy link
Collaborator

shnist commented Dec 12, 2018

hi @VincentRoth, thanks very much for taking the time to resolve the merge conflicts. The code looks fine to me. I'm going to merge it and do some testing and then will do a new release in the near future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants