Remove setup.cfg in favor of pyproject.toml #58
Conversation
|
|
pvlib-python uses |
|
With the new modification, the dynamic versioning seems to work. I verified this by pip installing the package from my local development repository and checking the version |
pyproject.toml
Outdated
| "Intended Audience :: Science/Research", | ||
| ] | ||
| dependencies = [ | ||
| 'importlib-metadata; python_version<"3.10"', |
There was a problem hiding this comment.
Where did importlib-metadata come from? Do we need it? I thought it was only needed for python<3.8.
pyproject.toml
Outdated
| "setuptools>=42", | ||
| "wheel" | ||
| ] | ||
| requires = ["setuptools", "setuptools-scm"] |
There was a problem hiding this comment.
We should require >=61 for setuptools, since that's when it started supporting pyproject.toml/PEP 621.
https://setuptools.pypa.io/en/stable/history.html#v61-0-0
pyproject.toml
Outdated
| authors = [ | ||
| {name = "Adam R. Jensen", email = "adam-r-j@hotmail.com"}, | ||
| {name = "Kevin S. Anderson"}, | ||
| ] |
There was a problem hiding this comment.
This results in the wheel's METADATA file including this, which doesn't seem quite right to me:
Author: Kevin S. Anderson
Author-email: "Adam R. Jensen" <adam-r-j@hotmail.com>
The v0.2.5 wheel on PyPI has this, which seems better to me:
Author: 'Adam R. Jensen, Kevin Anderson'
Author-email: adam-r-j@hotmail.com
There was a problem hiding this comment.
This seems like a strange behavior, see explanation below from this link. I've made my email in a separate email entry now.
If only name is provided, the value goes in Author or Maintainer as appropriate.
If only email is provided, the value goes in Author-email or Maintainer-email as appropriate.
If both email and name are provided, the value goes in Author-email or Maintainer-email as appropriate, with the format {name} <{email}>.
Multiple values should be separated by commas.
There was a problem hiding this comment.
In the twoaxistracking.egg-info/PKG-INFO file this now lists as:
Author: Adam R. Jensen, Kevin S. Anderson
Author-email: adam-r-j@hotmail.com
Closes #57