Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bifacial merge, improve merge tests #747

Merged
merged 29 commits into from
Jul 20, 2019

Commits on Jul 8, 2019

  1. Simplify merge method.

    Simplify merge method by using list and dictionary comprehensions instead of
    nested for loops. This also avoids the need to check if some of the elements
    of the reports arguments are None, and the need to check if reports contains
    more than one report. This should also be a small performance improvement.
    This change also adds a bit more detail to the docstring for the merge method.
    The creation of a new empty report is also modified to no longer use an
    intermediary list of keys.
    alexandermorgan committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    0d4cb80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55d8f08 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c969994 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    93d0559 View commit details
    Browse the repository at this point in the history
  5. Fix linting errors.

    alexandermorgan committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    e244343 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Configuration menu
    Copy the full SHA
    84d7189 View commit details
    Browse the repository at this point in the history
  2. Update v0.7.1.rst

    alexandermorgan authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    d131657 View commit details
    Browse the repository at this point in the history
  3. Revert "Update v0.7.1.rst"

    This reverts commit d131657.
    alexandermorgan committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    94f2db5 View commit details
    Browse the repository at this point in the history
  4. Revert "Remove pandas and numpy version reqs"

    This reverts commit 84d7189.
    alexandermorgan committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    4fdb599 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1429d5 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Configuration menu
    Copy the full SHA
    e12b807 View commit details
    Browse the repository at this point in the history
  2. Fix handling of None values in merge.

    If one of the values in the reports argument that merge() takes is a None,
    this is now properly handled by being dropped.
    alexandermorgan committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    25da151 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Remove unnecessary checks in merge().

    Returns merge method to its original state with two nested for loops, but without
    the checks for the number of dictionaries in the reports argument, or the check
    that each element in reports is a dictionary. Reports are only created in the build
    method so a test was made to ensure that build always returns a dictionary instead.
    alexandermorgan committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    feb7bf3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    079bb48 View commit details
    Browse the repository at this point in the history
  3. Fix lint errors.

    alexandermorgan committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    2189952 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Correct import mistake.

    Previous commits I made did not import the PVFactorsReportBuilder
    class correctly.
    alexandermorgan committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    39c2889 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eeb8053 View commit details
    Browse the repository at this point in the history
  3. Revert "Reinsert type check in merge loop."

    This reverts commit eeb8053.
    alexandermorgan committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    465d228 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c108362 View commit details
    Browse the repository at this point in the history
  5. Update what's new file.

    Add bullet point about added tests for bifacial.py methods.
    alexandermorgan committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    4447e6c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    74c8eba View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2019

  1. Revert "Fix merge conflicts in what's new file."

    This reverts commit 74c8eba.
    alexandermorgan committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    4eaf93f View commit details
    Browse the repository at this point in the history
  2. Revert "Update what's new file."

    This reverts commit 4447e6c.
    alexandermorgan committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    b2ed214 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c2fbecb View commit details
    Browse the repository at this point in the history
  4. Revert "Update whatsnew file syntax."

    This reverts commit c969994.
    alexandermorgan committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    fa9b64a View commit details
    Browse the repository at this point in the history
  5. Revert "Update what's new doc."

    This reverts commit 55d8f08.
    alexandermorgan committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    be8ec1c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    80809f2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    797dc83 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bd0740a View commit details
    Browse the repository at this point in the history