-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor bifacial merge, improve merge tests #747
Commits on Jul 8, 2019
-
Simplify merge method by using list and dictionary comprehensions instead of nested for loops. This also avoids the need to check if some of the elements of the reports arguments are None, and the need to check if reports contains more than one report. This should also be a small performance improvement. This change also adds a bit more detail to the docstring for the merge method. The creation of a new empty report is also modified to no longer use an intermediary list of keys.
Configuration menu - View commit details
-
Copy full SHA for 0d4cb80 - Browse repository at this point
Copy the full SHA 0d4cb80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55d8f08 - Browse repository at this point
Copy the full SHA 55d8f08View commit details -
Configuration menu - View commit details
-
Copy full SHA for c969994 - Browse repository at this point
Copy the full SHA c969994View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93d0559 - Browse repository at this point
Copy the full SHA 93d0559View commit details -
Configuration menu - View commit details
-
Copy full SHA for e244343 - Browse repository at this point
Copy the full SHA e244343View commit details
Commits on Jul 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 84d7189 - Browse repository at this point
Copy the full SHA 84d7189View commit details -
Configuration menu - View commit details
-
Copy full SHA for d131657 - Browse repository at this point
Copy the full SHA d131657View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94f2db5 - Browse repository at this point
Copy the full SHA 94f2db5View commit details -
Revert "Remove pandas and numpy version reqs"
This reverts commit 84d7189.
Configuration menu - View commit details
-
Copy full SHA for 4fdb599 - Browse repository at this point
Copy the full SHA 4fdb599View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1429d5 - Browse repository at this point
Copy the full SHA d1429d5View commit details
Commits on Jul 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e12b807 - Browse repository at this point
Copy the full SHA e12b807View commit details -
Fix handling of None values in merge.
If one of the values in the reports argument that merge() takes is a None, this is now properly handled by being dropped.
Configuration menu - View commit details
-
Copy full SHA for 25da151 - Browse repository at this point
Copy the full SHA 25da151View commit details
Commits on Jul 11, 2019
-
Remove unnecessary checks in merge().
Returns merge method to its original state with two nested for loops, but without the checks for the number of dictionaries in the reports argument, or the check that each element in reports is a dictionary. Reports are only created in the build method so a test was made to ensure that build always returns a dictionary instead.
Configuration menu - View commit details
-
Copy full SHA for feb7bf3 - Browse repository at this point
Copy the full SHA feb7bf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 079bb48 - Browse repository at this point
Copy the full SHA 079bb48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2189952 - Browse repository at this point
Copy the full SHA 2189952View commit details
Commits on Jul 12, 2019
-
Previous commits I made did not import the PVFactorsReportBuilder class correctly.
Configuration menu - View commit details
-
Copy full SHA for 39c2889 - Browse repository at this point
Copy the full SHA 39c2889View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeb8053 - Browse repository at this point
Copy the full SHA eeb8053View commit details -
Revert "Reinsert type check in merge loop."
This reverts commit eeb8053.
Configuration menu - View commit details
-
Copy full SHA for 465d228 - Browse repository at this point
Copy the full SHA 465d228View commit details -
Configuration menu - View commit details
-
Copy full SHA for c108362 - Browse repository at this point
Copy the full SHA c108362View commit details -
Add bullet point about added tests for bifacial.py methods.
Configuration menu - View commit details
-
Copy full SHA for 4447e6c - Browse repository at this point
Copy the full SHA 4447e6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74c8eba - Browse repository at this point
Copy the full SHA 74c8ebaView commit details
Commits on Jul 13, 2019
-
Revert "Fix merge conflicts in what's new file."
This reverts commit 74c8eba.
Configuration menu - View commit details
-
Copy full SHA for 4eaf93f - Browse repository at this point
Copy the full SHA 4eaf93fView commit details -
Revert "Update what's new file."
This reverts commit 4447e6c.
Configuration menu - View commit details
-
Copy full SHA for b2ed214 - Browse repository at this point
Copy the full SHA b2ed214View commit details -
Revert "Rename whatsnew file to change format to rst."
This reverts commit 93d0559.
Configuration menu - View commit details
-
Copy full SHA for c2fbecb - Browse repository at this point
Copy the full SHA c2fbecbView commit details -
Revert "Update whatsnew file syntax."
This reverts commit c969994.
Configuration menu - View commit details
-
Copy full SHA for fa9b64a - Browse repository at this point
Copy the full SHA fa9b64aView commit details -
Configuration menu - View commit details
-
Copy full SHA for be8ec1c - Browse repository at this point
Copy the full SHA be8ec1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80809f2 - Browse repository at this point
Copy the full SHA 80809f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 797dc83 - Browse repository at this point
Copy the full SHA 797dc83View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd0740a - Browse repository at this point
Copy the full SHA bd0740aView commit details