ENH: infinite sheds #717

mikofski · 2019-05-10T09:41:09Z

~~[ ] Closes issue #xxxx~~
I am familiar with the contributing guidelines.
Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
Updates entries to docs/sphinx/source/api.rst for API changes.
Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
Pull request is nearly complete and ready for detailed review.

Implements "infinite sheds" model for irradiance on long, regular bifacial array (fixed or single-axis tracked) on horizontal ground.

* add _to_radians and is_rad to convert only if necessary * prefix all functions with get_ * add get_f_sky_pv, get_poa_sky_pv, get_ground_angle_tangent, get_f_gnd_pv, get_f_gnd_pv, get_poa_gnd_pv, etc. * update API ui Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>

…irradiance

docs/sphinx/source/api.rst

…t defined

* get_irradiance, output ordered dict or dataframe * finish updating get_poa_global_bifacial to transpose beam and diffuse for each side separately

…ion" - use tan(zenith) in solar projection math latex - implement gcr_prime and ground-sky-angles calculations - add stub for ground-diffuse view factor Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>

…o infinite_sheds

- calculate ground-sky angles to previous and next rows, assuming height is nonzero - calculate limits on ground where it can see the sky - calculate the view factor as a function of z on the ground to the sky - fix places where it still says degrees, bad, no! - add fixme for pv-sky view factor, still has wrong formula - add tests for angles from point z on the ground to tops of current row, and limits of previous and next rows - add a script to make the plot of ground-sky view factor versus z

mikofski · 2019-07-04T00:36:36Z

Sorry for the delay. Getting closer! Here's the view factor of the sky diffuse from the ground between rows as a function of point z on the ground between rows, starting where the line from the panel intersects the ground:

this is generated by a script in pvlib/tests/test_infinite_sheds.py

mikofski · 2019-07-04T00:38:24Z

@wholmgren FYI: looks like pandas and other versions not supported by python-3.5, not sure?

- add comments, change names x->z - add TODO's to limit number of rows, and set row-type: 'first', 'last', or 'middle'

- was difference of angles, should be difference of cosines - also add TODO's to return VF versus point x on panel, and don't use averages

wholmgren · 2019-07-04T01:56:59Z

Cliff mentioned that in the ivtools pr (I think). I haven’t had a chance to look into it. Probably should be addressed in a separate pr.

…

On Wed, Jul 3, 2019 at 5:38 PM Mark Mikofski ***@***.***> wrote: @wholmgren <https://github.com/wholmgren> FYI: looks like pandas and other versions not supported by python-3.5 <https://travis-ci.org/pvlib/pvlib-python/jobs/554012857#L379>, not sure? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#717?email_source=notifications&email_token=ABBOER75RFF75U7MYDRY3DLP5VBAFA5CNFSM4HMBP67KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZGAEYQ#issuecomment-508297826>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBOER4OIOK4O57A5QKOCZLP5VBAFANCNFSM4HMBP67A> .

- change calc_fx_sky to calc_fz_sky since z is for ground and x is for pv surface - add docstring to calc_fz_sky and for ground_sky_diffuse_view_factor

pvlib/bifacial/infinite_sheds.py

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>

cwhanse · 2022-02-13T21:30:00Z

Terminology issue: pvlib isn't consistent in terms referring to solar zenith and solar azimuth.

The last set of changes here renamed two parameters: solar_zenith to apparent_zenith, and solar_azimuth to azimuth. solar_zenith and solar_azimuth are used in pvlib/tracking.py without specifying specify true or refraction-corrected zenith. In pvlib/irradiance.py, solar_zenith is used for refraction-corrected zenith. apparent_zenith is used in pvlib/solar_position.py for the refraction-corrected value, zenith for the true value, with azimuth.

So pvlib isn't consistent in these terms, and in places is not specific. With that in mind I'm going to open a discussion about the zenith term, so we can have a goal, and this PR can step towards that goal for the bifacial code.

adriesse · 2022-02-13T21:38:08Z

In my own code have standardized on zenith to refer to refraction-corrected solar zenith angle. I don't usually need the other one.

mikofski · 2022-02-14T00:49:26Z

I think this is ready to merge. @wholmgren wanna do the honors?

mikofski · 2022-02-17T19:16:50Z

If no one has any objections I'll merge this today, COB, okay?

wholmgren

@mikofski thanks, I forgot about this, but I'll let you do the honors when ready. My comments are not blockers.

wholmgren · 2022-02-17T19:33:39Z

pvlib/bifacial/infinite_sheds.py

@@ -0,0 +1,831 @@
+r"""


This is a nice module docstring, but I don't think it's rendered anywhere. Did I miss it? I don't recall rendering any module docstrings (for better or worse). I do recall that it might not be super simple for our current documentation strategy. If so, perhaps the doc string could be copied into another place, like a new bifacial.rst or an example gallery py file?

@cwhanse any comment on this? Seems like a good idea to me. I happy to move it if you agree. thx.

+1 to bifacial.rst

wholmgren · 2022-02-17T19:38:35Z

pvlib/bifacial/infinite_sheds.py

+def get_irradiance_poa(surface_tilt, surface_azimuth, apparent_zenith,
+                       azimuth, gcr, height, pitch, ghi, dhi, dni,


Given where #1403 is going, I suggest we go with solar_zenith and solar_azimuth like we do here

pvlib-python/pvlib/irradiance.py

Lines 304 to 305 in c0c46b4

def get_total_irradiance(surface_tilt, surface_azimuth,

solar_zenith, solar_azimuth,

Should we wait until after #1403 is closed to merge this PR?

wholmgren · 2022-02-17T19:39:39Z

pvlib/bifacial/infinite_sheds.py

+
+    Returns
+    -------
+    output : OrderedDict or DataFrame


A few years later, perhaps we just go with dict instead of OrderedDict?

@wholmgren do you mean change only the docstring, or replace the use of OrderedDict with {}?

Replace the use

pvlib/bifacial/infinite_sheds.py

pvlib/bifacial/utils.py

cwhanse · 2022-02-17T19:58:48Z

If no one has any objections I'll merge this today, COB, okay?

I'd prefer to resolve the solar_zenith question before merging. See discussion in #1403

…thon into infinite_sheds

kandersolar

A few sphinx rendering issues

docs/sphinx/source/user_guide/bifacial.rst

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

cwhanse · 2022-02-21T23:24:27Z

@wholmgren @kanderso-nrel I think I have addressed all comments. I'm satisfied that this PR is ready to merge. @mikofski want the honor of pushing the big green button?

kdebrab · 2024-09-01T07:42:50Z

pvlib/bifacial/utils.py

+                                        surface_azimuth)
+    f_gnd_beam = 1.0 - np.minimum(
+        1.0, gcr * np.abs(cosd(surface_tilt) + sind(surface_tilt) * tan_phi))
+    np.where(solar_zenith > max_zenith, 0., f_gnd_beam)  # [1], Eq. 4


@mikofski I think this line has no effect as there is no return value.

That's a point, well spotted @kdebrab ! Would you like to open a PR fixing it?

This line is probably supposed to start with f_gnd_beam = and clip it at max zenith so values don’t blow up.
ICYMI @cwhanse @kandersolar

I agree with @mikofski, that was the intent.

these lines are still unchanged in main:

f_gnd_beam = 1.0 - np.minimum( 1.0, gcr * np.abs(cosd(surface_tilt) + sind(surface_tilt) * tan_phi)) np.where(solar_zenith > max_zenith, 0., f_gnd_beam) # [1], Eq. 4 return f_gnd_beam # 1 - min(1, abs()) < 1 always

was a PR forthcoming?

@mikofski has not been fixed, should have its own issue.

mikofski added 5 commits May 10, 2019 02:39

WIP: ENH: infinite sheds

865cbfa

DOC: add infinite_sheds to api.rst, docstrings form sky_angle

2d77d82

ENH: clean up docstrings, add 4-quad arctan2, add api docs, more get_…

246dd2b

…irradiance

DOC: fix latex math, use psi_t for top, psi_b for bottom

29333dd

wholmgren reviewed May 17, 2019

View reviewed changes

docs/sphinx/source/api.rst Outdated Show resolved Hide resolved

mikofski added 15 commits May 18, 2019 21:46

STY: don't use get_* for standard functions

51fe74d

ENH: create class methods to get irradiance, FIXME: front/back poa no…

0af1fc2

…t defined

TST: add infinite_sheads test, add infinite_sheds to pvlib-api

9690938

TST: ground illumination test

6d5c2cb

TST: coerce df to float, replace div/0 with nan

99fdc69

TST: set atol to 1e-6 to compare to CSV

680b700

TST: test for shade line

97d9664

TST: fix diffuse fraction NaN and Inf, consolidate front+back = 1 test

4931446

TST: add tests for sky angle, psi_top

7ec812b

ENH: STY: fix stickler, ignore binary operator breaks

7e97fcb

* get_irradiance, output ordered dict or dataframe * finish updating get_poa_global_bifacial to transpose beam and diffuse for each side separately

add fixmes for ground illumination and ground view factor

4a4e22e

ENH: BUG: DOC: change "ground-illumination" to "unshaded-ground-fract…

3045928

…ion" - use tan(zenith) in solar projection math latex - implement gcr_prime and ground-sky-angles calculations - add stub for ground-diffuse view factor Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>

Merge branch 'master' into infinite_sheds

b2d0496

Merge branch 'infinite_sheds' of github.com:mikofski/pvlib-python int…

4c2b3cd

…o infinite_sheds

mikofski added 3 commits July 3, 2019 17:41

ENH: BUG: remove gcr_prime from vf calc, not used

d32c144

- add comments, change names x->z - add TODO's to limit number of rows, and set row-type: 'first', 'last', or 'middle'

BUG: fix view factors formulas

da7611b

- was difference of angles, should be difference of cosines - also add TODO's to return VF versus point x on panel, and don't use averages

STY: shorten line in test_infinite_sheds for sum of angles at z1 limit

fde1851

mikofski added 3 commits July 9, 2019 20:14

Merge branch 'master' into infinite_sheds

8247fbe

DOC: update module docstring with process from Marion, et al.

f9eb300

- change calc_fx_sky to calc_fz_sky since z is for ground and x is for pv surface - add docstring to calc_fz_sky and for ground_sky_diffuse_view_factor

BUG: revert changes to ground and sky to pv surface view factors

15822ab

mikofski commented Feb 12, 2022

View reviewed changes

pvlib/bifacial/infinite_sheds.py Outdated Show resolved Hide resolved

cwhanse and others added 3 commits February 13, 2022 10:15

Apply suggestions from code review

5b1357b

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>

changes solar_zenith, solar_azimuth names

5d1b778

Update pvlib/bifacial/infinite_sheds.py

03c49c0

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>

DOI directive in infinite_sheds.get_irradiance

764f807

Merge branch 'master' into infinite_sheds

da34555

wholmgren approved these changes Feb 17, 2022

View reviewed changes

kandersolar mentioned this pull request Feb 17, 2022

Add variable mapping of psm3 #1374

Merged

6 tasks

cwhanse mentioned this pull request Feb 17, 2022

More common terms for solar zenith and solar azimuth #1403

Open

cwhanse added 5 commits February 21, 2022 10:48

change back to solar_zenith, solar_azimuth

5688240

Merge branch 'infinite_sheds' of https://github.com/mikofski/pvlib-py…

80fb2b6

…thon into infinite_sheds

rename in test_utils

60fa642

OrderedDict to dict

8bc1d1d

create bifacial.rst

87d472a

kandersolar reviewed Feb 21, 2022

View reviewed changes

cwhanse and others added 3 commits February 21, 2022 15:32

Update docs/sphinx/source/user_guide/bifacial.rst

2c9d4c9

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

Apply suggestions from code review

1a7c33c

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

remove OrderedDict

b2c19a7

mikofski merged commit 63c36db into pvlib:master Feb 22, 2022

cwhanse mentioned this pull request Feb 23, 2022

port Purdue bifacial irradiance model #914

Closed

8 tasks

kandersolar mentioned this pull request Mar 7, 2023

Add shaded fraction (FS) calculation for true-tracking on flat terrain #1689

Closed

mikofski deleted the infinite_sheds branch March 13, 2023 18:39

kdebrab reviewed Sep 1, 2024

View reviewed changes

mikofski mentioned this pull request Oct 9, 2024

Infinite sheds beam fraction on ground zenith guardrail syntax bug #2245

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: infinite sheds #717

ENH: infinite sheds #717

mikofski commented May 10, 2019 •

edited by cwhanse

Loading

mikofski commented Jul 4, 2019

mikofski commented Jul 4, 2019

wholmgren commented Jul 4, 2019 via email

cwhanse commented Feb 13, 2022

adriesse commented Feb 13, 2022

mikofski commented Feb 14, 2022

mikofski commented Feb 17, 2022

wholmgren left a comment

wholmgren Feb 17, 2022

mikofski Feb 17, 2022

cwhanse Feb 17, 2022

wholmgren Feb 17, 2022

mikofski Feb 17, 2022

wholmgren Feb 17, 2022

cwhanse Feb 21, 2022

wholmgren Feb 21, 2022

cwhanse commented Feb 17, 2022

kandersolar left a comment

cwhanse commented Feb 21, 2022

kdebrab Sep 1, 2024

echedey-ls Sep 1, 2024

mikofski Sep 1, 2024

cwhanse Sep 1, 2024

mikofski Oct 8, 2024

cwhanse Oct 8, 2024

		def get_irradiance_poa(surface_tilt, surface_azimuth, apparent_zenith,
		azimuth, gcr, height, pitch, ghi, dhi, dni,

	def get_total_irradiance(surface_tilt, surface_azimuth,
	solar_zenith, solar_azimuth,

ENH: infinite sheds #717

ENH: infinite sheds #717

Conversation

mikofski commented May 10, 2019 • edited by cwhanse Loading

mikofski commented Jul 4, 2019

mikofski commented Jul 4, 2019

wholmgren commented Jul 4, 2019 via email

cwhanse commented Feb 13, 2022

adriesse commented Feb 13, 2022

mikofski commented Feb 14, 2022

mikofski commented Feb 17, 2022

wholmgren left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwhanse commented Feb 17, 2022

kandersolar left a comment

Choose a reason for hiding this comment

cwhanse commented Feb 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikofski commented May 10, 2019 •

edited by cwhanse

Loading