Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show distribution file sizes in publish.yml GH Actions workflow #2278

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kandersolar
Copy link
Member

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

With ongoing work around reducing the size of our distribution files, it is helpful to log the filesize in PR dist builds.

@kandersolar kandersolar added development_workflow build tools Pipelines, CI, GH actions labels Oct 22, 2024
@kandersolar kandersolar added this to the v0.11.2 milestone Oct 22, 2024
@kandersolar
Copy link
Member Author

The publish job now shows filesizes for the distribution files:

-rw-r--r-- 1 runner docker 28M Oct 22 20:59 dist/pvlib-0.11.2.dev21+g698a7cf-py3-none-any.whl
-rw-r--r-- 1 runner docker 34M Oct 22 20:59 dist/pvlib-0.11.2.dev21+g698a7cf.tar.gz

and installed files:

60K	pvlib/bifacial/__pycache__
124K	pvlib/bifacial
16K	pvlib/spa_c_files/__pycache__
40K	pvlib/spa_c_files
58M	pvlib/data
688K	pvlib/__pycache__
36K	pvlib/tests/bifacial/__pycache__
76K	pvlib/tests/bifacial
408K	pvlib/tests/__pycache__
40K	pvlib/tests/spectrum/__pycache__
84K	pvlib/tests/spectrum
132K	pvlib/tests/iotools/__pycache__
288K	pvlib/tests/iotools
40K	pvlib/tests/ivtools/__pycache__
88K	pvlib/tests/ivtools
1.5M	pvlib/tests
76K	pvlib/spectrum/__pycache__
160K	pvlib/spectrum
224K	pvlib/iotools/__pycache__
492K	pvlib/iotools
80K	pvlib/ivtools/__pycache__
180K	pvlib/ivtools
62M	pvlib

Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea and nice PR. Minor suggestions down below, feel free to discard them. I would prefer to have all the sizes in the same step so it gets expanded in a click, but it's fine as is.

.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build tools Pipelines, CI, GH actions development_workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants