Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated pvsystem.sapm_spectral_loss #2244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated pvsystem.sapm_spectral_loss #2244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pvlib/pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2273,12 +2273,6 @@ def sapm(effective_irradiance, temp_cell, module):
return out


sapm_spectral_loss = deprecated(
since='0.10.0',
alternative='pvlib.spectrum.spectral_factor_sapm'
)(spectrum.spectral_factor_sapm)


def sapm_effective_irradiance(poa_direct, poa_diffuse, airmass_absolute, aoi,
module):
r"""
Expand Down
6 changes: 0 additions & 6 deletions pvlib/tests/test_pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,6 @@ def test_PVSystem_multi_array_sapm(sapm_module_params):
system.sapm(500, temp_cell)


def test_sapm_spectral_loss_deprecated(sapm_module_params):
with pytest.warns(pvlibDeprecationWarning,
match='Use pvlib.spectrum.spectral_factor_sapm'):
pvsystem.sapm_spectral_loss(1, sapm_module_params)


def test_PVSystem_sapm_spectral_loss(sapm_module_params, mocker):
mocker.spy(spectrum, 'spectral_factor_sapm')
system = pvsystem.PVSystem(module_parameters=sapm_module_params)
Expand Down