-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct racking_model
default value, add freestanding
option
#2232
base: main
Are you sure you want to change the base?
Conversation
I have limited these changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with limiting the formatting fixes to the functions/classes touched by the primary purpose of the PR.
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
…ython into pvsystem_racking
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
…ython into pvsystem_racking
racking_module
andmodule_type
inPVSystem
docstring #1942Tests addedUpdates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Updated docstring value forracking_model
fromopen_rack
toNone
(comment)freestanding
option forracking_model
racking_model
, if I have understood correctly)AddedNone
as default value formodule_height
Other changes:
Formatting, minor edits (backticks, units, remove unused package, etc.)