Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Muneer transposition model #2184

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

Add Muneer transposition model #2184

wants to merge 55 commits into from

Commits on Aug 26, 2024

  1. muneer transposition model 

    still not tested
    @bernatnic
    bernatnic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    02ae568 View commit details
    Browse the repository at this point in the history

  2. Update pvlib/irradiance.py 

    Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ea15728 View commit details
    Browse the repository at this point in the history

  3. Update pvlib/irradiance.py 

    Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    feafcea View commit details
    Browse the repository at this point in the history

  4. Update pvlib/irradiance.py 

    Adam initial review

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e4646d4 View commit details
    Browse the repository at this point in the history

  5. Update pvlib/irradiance.py 

    Adam initial review

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8066458 View commit details
    Browse the repository at this point in the history

  6. Update pvlib/irradiance.py 

    Adam initial review

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1798da8 View commit details
    Browse the repository at this point in the history

  7. Update pvlib/irradiance.py 

    Adam initial review

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4281d61 View commit details
    Browse the repository at this point in the history

  8. references modified and doi added 

    Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8b13595 View commit details
    Browse the repository at this point in the history

  9. removed unwanted file

    @BernatNicolau
    BernatNicolau committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6cd63a8 View commit details
    Browse the repository at this point in the history

  10. formating autopep8

    @BernatNicolau
    BernatNicolau committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fa4d8e6 View commit details
    Browse the repository at this point in the history

  11. formatting

    @BernatNicolau
    BernatNicolau committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8318d5b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. avoid references first paragraph 

    Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
    @BernatNicolau @echedey-ls
    BernatNicolau and echedey-ls authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d5c8bc3 View commit details
    Browse the repository at this point in the history

  2. updated wording 

    Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
    @BernatNicolau @echedey-ls
    BernatNicolau and echedey-ls authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8cbee57 View commit details
    Browse the repository at this point in the history

  3. function finished 

    still needs testing
    @BernatNicolau
    BernatNicolau committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    20c8fae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'muneer' of https://github.com/BernatNicolau/pvlib-python … 

    …into muneer
    @BernatNicolau
    BernatNicolau committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a326e94 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. pvlib.irradiance update (muneer) 

    muneer included in get_sky_diffuse code and documentation
muneer included in get_total_irradiance documentation
muneer function updated

TODO: tests, create documentation
    @BernatNicolau
    BernatNicolau committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e0d85c0 View commit details
    Browse the repository at this point in the history

  2. documentation, tests and flake8 

    added documentation, tests and modifications according to flake8
    @BernatNicolau
    BernatNicolau committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    30fb33a View commit details
    Browse the repository at this point in the history

  3. flake8 update 

    still quite new to the flake8. May not pass the test
    @BernatNicolau
    BernatNicolau committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e1a7f74 View commit details
    Browse the repository at this point in the history

  4. test_added

    @BernatNicolau
    BernatNicolau committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    618ca91 View commit details
    Browse the repository at this point in the history

  5. flake8

    @BernatNicolau
    BernatNicolau committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    373d3e0 View commit details
    Browse the repository at this point in the history

  6. E501

    @BernatNicolau
    BernatNicolau committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e517a84 View commit details
    Browse the repository at this point in the history

  7. update whatsnew

    @BernatNicolau
    BernatNicolau committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9452248 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into muneer

    @BernatNicolau
    BernatNicolau authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b2d5239 View commit details
    Browse the repository at this point in the history

  9. Update docs/sphinx/source/whatsnew/v0.11.1.rst 

    replace . by ,

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    36f633e View commit details
    Browse the repository at this point in the history

  10. documentation improvement 

    Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    982d2f9 View commit details
    Browse the repository at this point in the history

  11. documentation improvement 

    Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    eecc05e View commit details
    Browse the repository at this point in the history

  12. documentation improvement 

    Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
    @BernatNicolau @AdamRJensen
    BernatNicolau and AdamRJensen authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    83b5036 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into muneer

    @BernatNicolau
    BernatNicolau authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6bd1d51 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. b added to get_total_irradiance

    @BernatNicolau
    BernatNicolau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4fb4bae View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Apply suggestions from code review (documentation) 

    Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
    @BernatNicolau @echedey-ls @RDaxini
    3 people authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4c69d6f View commit details
    Browse the repository at this point in the history

  2. flake8-linter

    @BernatNicolau
    BernatNicolau committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b93aa05 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Update DOI 

    Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
    @BernatNicolau @RDaxini
    BernatNicolau and RDaxini authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c2248f1 View commit details
    Browse the repository at this point in the history

  2. create scenario with low solar altitude (<0.1rad)

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    91fd117 View commit details
    Browse the repository at this point in the history

  3. avoid zero in denominator

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b8910de View commit details
    Browse the repository at this point in the history

  4. division by zero fix

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0591323 View commit details
    Browse the repository at this point in the history

  5. solar_azimuth is not optional anymore + test updated

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    aed0e6d View commit details
    Browse the repository at this point in the history

  6. # GH 432

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2d4b10f View commit details
    Browse the repository at this point in the history

  7. test_update

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    bec7412 View commit details
    Browse the repository at this point in the history

  8. replace np.where by .where to keep the pd.Series type

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a3e3e3c View commit details
    Browse the repository at this point in the history

  9. revert np.where and modify type if needed

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    927c8a8 View commit details
    Browse the repository at this point in the history

  10. typo when converting sky_diffuse

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7cfd605 View commit details
    Browse the repository at this point in the history

  11. improvement # GH 432

    @BernatNicolau
    BernatNicolau committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5298cb2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. np.array and float tests added

    @BernatNicolau
    BernatNicolau committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ce6f5c0 View commit details
    Browse the repository at this point in the history

  2. updated expected to np.array as it should be

    @BernatNicolau
    BernatNicolau committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ce42241 View commit details
    Browse the repository at this point in the history

  3. assert_series_equal to assert_almost_equal

    @BernatNicolau
    BernatNicolau committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5632bda View commit details
    Browse the repository at this point in the history

  4. documentation improvement 

    Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
    @BernatNicolau @cwhanse
    BernatNicolau and cwhanse authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b2128cf View commit details
    Browse the repository at this point in the history

  5. linter

    @BernatNicolau
    BernatNicolau committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f9fb65c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
    @BernatNicolau @RDaxini
    BernatNicolau and RDaxini authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c0caf04 View commit details
    Browse the repository at this point in the history

  7. unify irradiation unit format

    @BernatNicolau
    BernatNicolau committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2142559 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'muneer' of https://github.com/BernatNicolau/pvlib-python … 

    …into muneer
    @BernatNicolau
    BernatNicolau committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4e58192 View commit details
    Browse the repository at this point in the history

  9. linter

    @BernatNicolau
    BernatNicolau committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bedd18b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. muneer2004

    @BernatNicolau
    BernatNicolau committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b5e4aec View commit details
    Browse the repository at this point in the history

  2. overcast condition

    @BernatNicolau
    BernatNicolau committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1bcf20d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. update clearness index

    @BernatNicolau
    BernatNicolau committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c9b9214 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge pull request #1 from BernatNicolau/muneer-book 

    Muneer from book adaptation
    @BernatNicolau
    BernatNicolau authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    519861e View commit details
    Browse the repository at this point in the history