Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #2178

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Fixed typo #2178

merged 7 commits into from
Aug 29, 2024

Conversation

marc-resc
Copy link
Contributor

@marc-resc marc-resc commented Aug 22, 2024

  • Closes Yet another documentation typo #2160
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@cwhanse
Copy link
Member

cwhanse commented Aug 26, 2024

@mrue-pv can you correct the conflict in the what's new file? I think you can delete the conflict line markers and keep all the changes, from your PR and the other PRs.

@cwhanse cwhanse added this to the v0.11.1 milestone Aug 26, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marc-resc! We hope to see more PRs from you 🥳

@kandersolar kandersolar merged commit e59d2b8 into pvlib:main Aug 29, 2024
30 checks passed
@marc-resc marc-resc deleted the fix_ez_typo branch August 30, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yet another documentation typo
3 participants