-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linear shade loss model - continuation of pr 1725 #2004
Linear shade loss model - continuation of pr 1725 #2004
Conversation
I found this by googling: It’s for series 4 but explains why linear shade for orientation perpendicular to cells |
I don't really get to see where it explains the shade is perpendicular to the cells. I mean, I see the statement but not the reasoning. I would prefer some other reference, although I'll stick to that one. I will update the PR by the end of the week. |
Maybe if you combine this reference with the FirstSolar series 4 user guide. The point is the cells are long and thin and strung in series from side to side. The user guide explains that they should only be oriented so that the cells extend from bottom to top, not left to right or damage will occur. There is also a series 6/7 user guide. |
Thanks for that insightful manual. I like how the docstring is turning out! These references don't have the model equation nor address what the model modifies (power yield or irradiance). I think it doesn't matter as long as we find some other source that deals with the model eventually. Maybe some code snippet on the public domain under First Solar authorship? |
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
I have the feeling that the reference still is an issue. If you maintainers think so, do you think the same reference as #2063 and #2070 , equation (3), is a sustainable reference? https://www.sciencedirect.com/science/article/abs/pii/S092702481000454X Pro: it compares the results in Table 2 and Fig. 4. |
Hi @echedey-ls that reference isn’t really valid for firstsolar modules because firstsolar don’t use bypass diodes and the power loss isn’t exactly the same as the fraction of direct beam shaded, because there is still diffuse sky and ground. I think the best references are Kevin’s & Adam’s paper and the poster from PVPMC 2023 (https://pvpmc.sandia.gov/download/5381/?tmstv=1719027091). Saying the loss is linear is just industry jargon four saying there is no electrical mismatch due to shade, so the only loss is the linear decrease in direct beam. |
For me, yes. I don't think we have a reference that clearly describes the specific model implemented here. I spent some time previously trying to locate a better reference, but was unsuccessful. Without a good reference, I suggest we close this PR. It's easy enough to pick it back up again if/when a good reference becomes available in the future. |
I disagree. The first solar series 4, 6 & 7 manuals suffice. I will ask first Solar if they have something more definitive. Is the question:
There are references available for all of these questions already. Please do not close this PR. My preference would be to figure out how to complete it or merge as is. I don’t understand the blocker, but I do know that I am seeing more first solar modules on terrain and it will likely continue due to concerns over domestic manufacturing and tariffs |
The equations affect direct beam irradiance only, so add whatever diffuse light before evaluating effect on power. The reference for the equation is the poster from PVPMC 2023 |
Hey @mikofski , I plan on finishing development on all my PRs to pvlib for now unless straight interest is shown in certain proposals and I find the time to work on them. I will be closing this for these reasons, but feel free to copy this branch and continue development if you wish. Now that I better understand pvlib and the PV context, my two cents to consider that poster not enough to include it are the following:
Again, feel free to pick up this work and continue from there - I can support you with reviews; and thanks for showing interest in improving these capabilities of pvlib, I learnt a lot through this journey. |
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Addresses the linear thin film module losses.
Comment from @kandersolar at #1962:
@mikofski do you have a reference for that or should I change to irradiance losses and a SAM reference?
Wait for #1962 to be merged before this one so the docstring makes sense.