Fix error message modelchain.infer_temperature_model error to be more informative #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
reviewed
Mar 3, 2024
pvlib/modelchain.py
Outdated
| f'If Arrays are not used, check that the PVSystem ' | ||
| f'attributes `racking_model` and `module_type` ' | ||
| f'are valid.') | ||
| raise ValueError('could not infer temperature model from ' |
There was a problem hiding this comment.
Suggested change
| raise ValueError('could not infer temperature model from ' | |
| raise ValueError('Could not infer temperature model from ' |
There was a problem hiding this comment.
@matsuobasho this capitalization change will also require the tests to be updated. See the test failures here: https://github.com/pvlib/pvlib-python/actions/runs/8146219415/job/22264244062?pr=1977#step:9:134
…_model Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
kandersolar
reviewed
Mar 5, 2024
Spelling error correction in error message Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
|
@matsuobasho the tests on this PR are failing due to the match text needing to be updated as mentioned above. After that I think this PR will be ready to merge. |
|
@kandersolar thank you for the guidance on this, your message about the capitalization in the tests earlier in the week slipped past me. Will address. |
…specified with the correct error message from infer_tempertaure_model
kandersolar
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.