Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated plot_ghi_transposition.py #1450

Closed
wants to merge 6 commits into from
Closed

Conversation

RoyCoding8
Copy link
Contributor

@RoyCoding8 RoyCoding8 commented Apr 26, 2022

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Changed the unit from C to degree C (°C)
Changed to LaTeX \degree symbol in matplotlib which avoids any encoding issues with using Unicode characters.
Added name to the contributors' list
Made some changes in labels and comments; deleted a variable which is not required
@RoyCoding8
Copy link
Contributor Author

RoyCoding8 commented Apr 26, 2022

@kanderso-nrel @mikofski Hello, please let me know if there are some problems related to this PR. I am actually not able to understand if the failed build checks are related to my commit or not. Also, would you please help me with the conflicts that should be resolved?

@kandersolar
Copy link
Member

kandersolar commented Apr 26, 2022

The ReadTheDocs failure does not look related to your PR -- you can just ignore it and I'll look into that separately. Edit: oh, it's the same issue from #1434, which was fixed in #1435. The instructions below for updating your PR branch should get this working again.

The conflict is because pvlib's master branch has diverged from yours. For this reason in general it is best to make new branches instead of using your master branch for PRs. This might help with understanding why branching is useful, and how to "fix" your master branch and move the changes to a feature branch: https://stackoverflow.com/questions/67234269/how-to-bring-fork-up-to-date-to-make-clean-pull-requests

@RoyCoding8
Copy link
Contributor Author

Okay thanks @kanderso-nrel! I'll close this PR and create a new one :)

@RoyCoding8 RoyCoding8 closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants