Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_psm3, 0.9.0 whats new doc fixes #1169

Merged
merged 3 commits into from
Feb 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docs/sphinx/source/whatsnew/v0.9.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,20 @@ Enhancements
Bug fixes
~~~~~~~~~
* Pass weather data to solar position calculations in
:ref:meth:`~pvlib.modelchain.ModelChain.prepare_inputs_from_poa`.
:py:meth:`~pvlib.modelchain.ModelChain.prepare_inputs_from_poa`.
(:issue:`1065`, :pull:`1140`)
* Reindl model fixed to generate sky_diffuse=0 when GHI=0.
(:issue:`1153`, :pull:`1154`)

Testing
~~~~~~~

Documentation
~~~~~~~~~~~~~

* Update intro tutorial to highlight the use of historical meteorological data
and to make the procedural and OO results match exactly.
and to make the procedural and object oriented results match exactly.
* Update documentation links in :py:func:`pvlib.iotools.get_psm3`

Requirements
~~~~~~~~~~~~
Expand All @@ -127,3 +129,5 @@ Contributors
* Nate Croft (:ghuser:`ncroft-b4`)
* Kevin Anderson (:ghuser:`kanderso-nrel`)
* Adam R. Jensen (:ghuser:`AdamRJensen`)
* Joshua Stein (:ghuser:`jsstein`)
* Tony Lorenzo (:ghuser:`alorenzo175`)
4 changes: 2 additions & 2 deletions pvlib/iotools/psm3.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ def get_psm3(latitude, longitude, api_key, email, names='tmy', interval=60,
.. [1] `NREL National Solar Radiation Database (NSRDB)
<https://nsrdb.nrel.gov/>`_
.. [2] `Physical Solar Model (PSM) v3
<https://developer.nrel.gov/docs/solar/nsrdb/psm3_data_download/>`_
<https://developer.nrel.gov/docs/solar/nsrdb/psm3-download/>`_
.. [3] `Physical Solar Model (PSM) v3 TMY
<https://developer.nrel.gov/docs/solar/nsrdb/psm3_tmy_data_download/>`_
<https://developer.nrel.gov/docs/solar/nsrdb/psm3-tmy-download/>`_
.. [4] `Physical Solar Model (PSM) v3 - Five Minute Temporal Resolution
<https://developer.nrel.gov/docs/solar/nsrdb/psm3-5min-download/>`_
"""
Expand Down