Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pvlib.bifacial should contain module-to-sky and module-to-ground view factor calculations. #1082

Closed
stephenjkaplan opened this issue Oct 16, 2020 · 4 comments
Closed

pvlib.bifacial should contain module-to-sky and module-to-ground view factor calculations. #1082

stephenjkaplan opened this issue Oct 16, 2020 · 4 comments

Comments

@stephenjkaplan
Copy link

Pull Request #717 is currently in draft form and contains quite a bit of functionality. This issue addresses a more immediate need for view factor functions that have already been written and tested in that PR. This issue can be solved by simply refactoring functionality that calculates module to sky and module to ground view factor.

This issue is now a dependency for #1080
@stephenjkaplan stephenjkaplan mentioned this issue Oct 16, 2020
Merged
7 tasks
@stephenjkaplan
Copy link
Author

however, it's important to note that the versions of those functions that will be implemented in this PR assume a no shade sky view factor. the shaded sky view factor code has been factored out.

@mikofski
Copy link
Member

Can we please hold off on this for now, and consider the comments here?

@stephenjkaplan
Copy link
Author

Can we please hold off on this for now, and consider the comments here?

absolutely.

@stephenjkaplan
Copy link
Author

closed to prevent duplicate/complicating work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikofski @stephenjkaplan