Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Update shading.py * Minimal test * Implementation From NREL paper * Fix, fix, fix, fix & format * Format issues * Extend tests (compare with singleaxis) & format with ruff * Format fixes * Upgrade tests * Array -> Axis * type * Whatsnew * xd * bruh * Minor Python optimization a la tracking.singleaxis * Comment and minor optimizations * Surface -> Axis Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Elevation -> Zenith Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Elev -> Zenith Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update shading.py * Update docstring Co-Authored-By: Anton Driesse <9001027+adriesse@users.noreply.github.com> * Add comments from `tracking.singleaxis` Co-Authored-By: Will Holmgren <william.holmgren@gmail.com> Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com> * Singleaxis implementation port & test addition, based on old pvlib.tracking.singleaxis * Update v0.10.4.rst * Linter * Code review Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> * Add Fig 5 [1] (still gotta check the built output) * Add caption, change size and describe in alternate text * rST fixes ? * Figures have captions, images do not https://pandemic-overview.readthedocs.io/en/latest/myGuides/reStructuredText-Images-and-Figures-Examples.html#id18 * Flip arguments order * I forgot 💀 * Linter are you happy now? * Remove port test and add edge cases test Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update test_shading.py Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Indentation xd * Update test_shading.py * I forgot how to code * Align data * Docstring suggestion from Kevin Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update link to example? * add linear shade loss for thin films * add tests, update docs, what's new * fix what's new gh issue and pr links * fix trailing whitespace * responding to comments - move linear shade loss to shading module - don't use ternary, doesn't work on vectors, instead use np.where() - set cross axis default to zero - test vectors - update docs * update docstring for linear shade loss - applicable to other monolithic thin film like CIGS, not just CdTe - only when shade is perpendicular to scribe lines * update example in linear_shade_loss * add figure and formulas to shaded fraction * shaded fraction consistently * Add alternative text to image * Update implementation based on PSZ PR. See description. Commit highlights ✨ : * I think I made all the code a bit more legible; sorry for the big changes @mikofski * Tests a bit more complete (not much, still consider the same test data) * Rename shaded fraction acronym from `fs` to `sf` * Asserts changed to `assert_allclose` for a more legible output in case of failure Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com> * Whatsnew entries Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com> * Linter * Clear things, convert Mark's reference to a reference * Linter * Update according to changes at PSZA PR * Another commit, another try * Ahhh, I rebased too fast * whatsnews * Update v0.10.4.rst * Update v0.10.3.rst * Rename to `shaded_fraction1d`, change params to `surface_*` instead of `tracker_*` * Left this tracker refs behind * Change rename in rst entries * Add another testcase * Improve docs references, clarify nomenclature Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update test_shading.py * Remove linear_shade_loss * First implementation of the new shaded fraction model (missing figure) * Create Anderson_Jensen_2024_Fig3.png * Update shading.py * Update shading.py * Update shading.py * lintaaargggg * Fill reference * Next release 0.10.5? * Fix tests * Update test_shading.py * Little improvement to table definitions * Change `l` to `\ell` Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * `pvlib.tracking.projected_solar_zenith_angle` to `pvlib.shading.projected_solar_zenith_angle` Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * pitch references to `pitch` Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * `trackers_axis_azimuth` to `axis_azimuth` Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * whatsnews Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update v0.10.5.rst Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Change `tilt`s to `rotation`s and add `axis_tilt` Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Forgot to update tests 💀 Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Add examples section * roles assumption messin w/ me docs 😲 * roles assumption messin w/ me docs 😲 Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update shading.py * Update shading.py * Add gallery example * This was fixed in recent sphinx-gallery releases IIRC * Extra empty line or admonition type unsupported * Fix example link (hopefully 🙏 ) * Update shading.py * Fix subsubsections? * Nah, bulleted list didn't work * tilted -> tracker, only affects text * Typos and unreasonable physical values Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * See the Examples section below, not the unlinkable link Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * tracker -> row, param names, code and docs Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Fix broken example 🔧 Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * "the row axis/axes" instead of ``axis_azimuth`` * Unnecessary math mode Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Example suggestions and text trimming Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * whatsmes * Add test to fix coverage issue * Initial work * Can't test with the paper data, wtf * Little things * Update plot_martinez_shade_loss.py * More improvements * Be4 rebase * Fix fixture * Initial work * Fix tests * docstring * whatsnew 📝 * Minor thingies * Add figure, improve docs 💯 * Fix silently ignoring file path in `pvsystem.retrieve_sam` when `name` is provided (#2020) * My approach to the issue * Deprecate previous parameters * No reason to over-engineer, right? * Update v0.10.5.rst * Update pvsystem.py * Improve error handling * Add ppl involved * kevin's suggestions * Fix Ixx equation in pvsystem.sapm (#2019) * fix Ixx equation, use Aimp * Update docs/sphinx/source/whatsnew/v0.10.5.rst * lint * lint * get the spacing right * more spacing --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Increase python requirement to >= 3.8 (#2029) * require python >=3.8 * update CI configurations * whatsnew * remove pre-3.8 cruft * fix h5py/numpy versioning issue for py3.8-min * update gallery examples for newer pandas * update asv config for python 3.8 * fix asv config syntax error * one more asv config edit * Finalize 0.10.5 (#2035) * whatsnew cleanup * add v0.11.0 file * forgot to include myself in the contributors * update release date * Comments from review * update whatsnews * Update test_shading.py * Example * Fix whatsmes * Update v0.11.0.rst * other img * lintarrrrrr 😭 * docs * docs refurbishment * Update plot_martinez_shade_loss.py * Fix parameter names * More explicit 2D shaded fraction Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Explicitier explicit Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update shading.py Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Only if life was VCS to revert my errors so easily Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Nix image in docstring Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Clear-up irrdiance loss, not pwr loss - yet again Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * rewording Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Remove figure of junction boxes in example Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Duplicated singleaxis call Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * When did I change this? Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Rename function Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Make times just one statement Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Fix uncomplete example in docstring Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * flake is a snowflake ❄️ Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Delete Centralized_and_split_PV_junction_boxes_cesardd.jpg Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Remove example description Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> * Change example title Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> * Ints for number of blocks Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> * Rephrasing of shaded fraction 2D Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> * typo * Code review from Ioannis Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * no more noqa e501 * Will this work to hide code? * Update plot_martinez_shade_loss.py Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * play time with the matplotlib statements Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * This fixes it (I believe 🙏 ) CC @IoannisSifnaios Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * Update plot_martinez_shade_loss.py Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * Nah, let's see how this does Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * Revert attempt to colapse code It doesn't work because sphinx-gallery closes the figure at the end of the cell sphinx-gallery/sphinx-gallery#240 CC @IoannisSifnaios Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * Power losses model Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * equations rendering * Change `poa_direct_and_circumsolar` to `poa_direct` Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Example link Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * `power_loss` -> `loss_fraction` Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Typo when applying Ioannis suggestion Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> Co-Authored-By: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * Re-arrange POA to its own section in example Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Mis-redaction in normal/half-cut modules comparison Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Add edge cases Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Link yet again Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Fix link for sure Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Remove critical error from docs build * Apply suggestions from code review (Cliff) Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Linter * Apply suggestions from Adam Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Rewording from code review Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * More unitless Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Apply suggestions from Cliff Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> --------- Co-authored-by: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> Co-authored-by: Anton Driesse <9001027+adriesse@users.noreply.github.com> Co-authored-by: Will Holmgren <william.holmgren@gmail.com> Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com> Co-authored-by: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> Co-authored-by: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com>
- Loading branch information
10 people
authored
Jun 21, 2024
1 parent
3f2daab
commit 35599e7
