Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/746 update or create with ptime employee data #749

Draft
wants to merge 32 commits into
base: ptime-mapper-script
Choose a base branch
from
Draft

Feature/746 update or create with ptime employee data #749

wants to merge 32 commits into from

Conversation

RandomTannenbaum
Copy link
Collaborator

No description provided.

@RandomTannenbaum
Remove unwanted things from delayed job and start writing updating an…
c969ed0 
…d creating of people
@RandomTannenbaum
Make show method use new record if necessary
622913d
@RandomTannenbaum
Move new create and update logic to new class and make create redirec…
80d6b89 
…t to people if they already exist
@RandomTannenbaum
Make newly created people have default languages, refactor code
0d08852
@RandomTannenbaum
Start writing tests for updating person data on visit and remove spec…
c071a85 
…s and code from old updating version with delayed job
@RandomTannenbaum
Fix assigning and updating of nationalities and write test for creati…
b4d0f78 
…ng a person
@RandomTannenbaum
Write a spec that tests if create_person can return an already existi…
12ab636 
…ng person
@RandomTannenbaum
Write spec that tests ensures an error is raised when the person is n…
ec2bb14 
…ot found in the ptime api
@RandomTannenbaum
Make create_person method directly create the correct person without …
193f80a 
…creating a default person
@RandomTannenbaum
Clean up and fix specs, fix create_person method in update_person_dat…
61541a7 
…a class
@RandomTannenbaum
Start updating default language logic
c06233d
@RandomTannenbaum
Rename update_person_data from ptime namespace to people_employees
58a9824
@RandomTannenbaum
Rename create_person method to create_or_find
a724c45
@RandomTannenbaum RandomTannenbaum force-pushed the feature/746-update-or-create-with-ptime-employee-data branch from ca1ad07 to a724c45 Compare July 30, 2024 07:03
@RandomTannenbaum
Change way in which default languages are set
7037d7f
@RandomTannenbaum
Update tests with new helpers
9f018bc
@RandomTannenbaum
Make person controller work without time again, start writing initial…
5a81213 
…izer that will enable the ptime connection when wanted, fix docker compose
@RandomTannenbaum
Move setting of default languages to after_initialize and cleanup code
b9c7959
@RandomTannenbaum
Move ptime connection to concerns and rename it to people_controller
3874b7c
@RandomTannenbaum
Rename create_or_find to find_or_create
f5c5af3
@RandomTannenbaum
Fix a bug where default languages where added every time person was v…
684816e 
…isited
@RandomTannenbaum
Move some code from the update_person_data method to another method f…
54925b5 
…or better readabilty
@RandomTannenbaum
Fix typo in people_employees
b5f1053
@RandomTannenbaum
Write spec to test if default languages are created correctly
027e2f9
@RandomTannenbaum
Change insert to prepend in ptime initializer
2bcde37
@RandomTannenbaum
Simplify people_controller in ptime namespace
8cd1708
@RandomTannenbaum
Rewrite people_employees feature spec as request spec
0277ae5
@RandomTannenbaum
Fix ptime specs
4946cc9
@RandomTannenbaum
Make rubocop happy
b968351
@RandomTannenbaum RandomTannenbaum changed the base branch from master to ptime-mapper-script August 2, 2024 11:57
@RandomTannenbaum RandomTannenbaum linked an issue Aug 2, 2024 that may be closed by this pull request
Update People when they are viewed | PuzzleTime Sync #7 #746
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update People when they are viewed | PuzzleTime Sync #7
1 participant
@RandomTannenbaum