Skip to content

Commit

Permalink
Rename update_person_data from ptime namespace to people_employees
Browse files Browse the repository at this point in the history
  • Loading branch information
RandomTannenbaum committed Jul 30, 2024
1 parent c06233d commit 58a9824
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions app/controllers/people_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ def show
@person = Person.includes(projects: :project_technologies,
person_roles: [:role, :person_role_level]).find(@person.id)

Ptime::UpdatePersonData.new.update_person_data(@person)
Ptime::PeopleEmployees.new.update_person_data(@person)
super
end

def new
@person = Ptime::UpdatePersonData.new.create_person(params[:ptime_employee_id])
@person = Ptime::PeopleEmployees.new.create_person(params[:ptime_employee_id])
# (%w[DE EN FR] - @person.language_skills.pluck(:language)).each do |language|
# @person.language_skills.push(LanguageSkill.new({ language: language, level: 'A1' }))
# end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Ptime
class UpdatePersonData
class PeopleEmployees
def create_person(ptime_employee_id)
raise 'No ptime_employee_id provided' unless ptime_employee_id

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require 'rails_helper'

describe Ptime::UpdatePersonData do
describe Ptime::PeopleEmployees do
ptime_base_test_url = "www.ptime.example.com"
ptime_api_test_username = "test username"
ptime_api_test_password = "test password"
Expand All @@ -11,15 +11,15 @@
end

it 'should raise error when no ptime_employee_id is passed to new action' do
expect{ Ptime::UpdatePersonData.new.create_person(nil) }.to raise_error(RuntimeError, 'No ptime_employee_id provided')
expect{ Ptime::PeopleEmployees.new.create_person(nil) }.to raise_error(RuntimeError, 'No ptime_employee_id provided')
end

it 'should return person if it has the given ptime_employee_id' do
person_wally = people(:wally)
person_wally.ptime_employee_id = 123
person_wally.save!

new_person = Ptime::UpdatePersonData.new.create_person(person_wally.ptime_employee_id)
new_person = Ptime::PeopleEmployees.new.create_person(person_wally.ptime_employee_id)
expect(person_wally.attributes.except(*%w[created_at updated_at])).to eql(new_person.attributes.except(*%w[created_at updated_at]))
end

Expand All @@ -31,6 +31,6 @@
person_wally = people(:wally)
person_wally.ptime_employee_id = 50
person_wally.save!
expect{ Ptime::UpdatePersonData.new.update_person_data(person_wally) }.to raise_error(RuntimeError, 'Ptime_employee with ptime_employee_id 50 not found')
expect{ Ptime::PeopleEmployees.new.update_person_data(person_wally) }.to raise_error(RuntimeError, 'Ptime_employee with ptime_employee_id 50 not found')
end
end
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require 'rails_helper'

describe Ptime::UpdatePersonData do
describe Ptime::PeopleEmployees do
ptime_base_test_url = "www.ptime.example.com"
ptime_api_test_username = "test username"
ptime_api_test_password = "test password"
Expand Down

0 comments on commit 58a9824

Please sign in to comment.