avoid variable shadowing (getredash#4050)

pushpay · Nov 14, 2019 · 7266efd · 7266efd
1 parent 5576d3e
commit 7266efd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/redash/tasks/failure_report.py b/redash/tasks/failure_report.py
@@ -24,8 +24,8 @@ def comment_for(failure):
 
 @celery.task(name="redash.tasks.send_aggregated_errors")
 def send_aggregated_errors():
-    for key in redis_connection.scan_iter(key("*")):
-        user_id = re.search(r'\d+', key).group()
+    for k in redis_connection.scan_iter(key("*")):
+        user_id = re.search(r'\d+', k).group()
         send_failure_report(user_id)
 
 

diff --git a/tests/tasks/test_failure_report.py b/tests/tasks/test_failure_report.py
@@ -6,7 +6,7 @@
 
 from tests import BaseTestCase
 from redash import redis_connection, models, settings
-from redash.tasks.failure_report import notify_of_failure, send_failure_report, send_aggregated_errors, key
+from redash.tasks.failure_report import notify_of_failure, send_failure_report, key
 from redash.utils import json_loads
 
 class TestSendAggregatedErrorsTask(BaseTestCase):