Migrate towards customisable channel authorization strategies #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current HTTP authorisation code into a specific implementation. This moves us towards customisable authorisation strategies while maintaining the previous public API as a facade around the new internal implementation. This also simplifies the calls between PTPusher and PTPusherChannel, as the channel is no longer directly responsible for authorisation.
Cancellation seems unnecessary as we ignore any callbacks from the auth delegate if we are disconnected.
…nURL override it. Setting the auth delegate explicitly should always take precedence.
This lets us extend the API for modifying outgoing requests through the PTPusherChannelAuthorizationOperation class rather than just exposing what NSMutableURLRequest has to offer.
|
Closing in favour of #213. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening an early pull request for my work on extracting our current, hardcoded HTTP-based channel auth strategy into a customisable strategy system, that lets users of the library implement channel authorization however they like (e.g. HTTP using a library of their own choice, not using HTTP at all etc.).
/cc @mloughran @aschuch