spago init template based on Spec #1264
Conversation
test/Prelude.purs
Outdated
| @@ -26,7 +26,7 @@ import Spago.Command.Init as Init | |||
| import Spago.Core.Config (Dependencies(..), Config) | |||
| import Spago.Core.Config as Config | |||
| import Spago.FS as FS | |||
| import Spago.Prelude as X | |||
| import Spago.Prelude (class Applicative, class Apply, class Bind, class BooleanAlgebra, class Bounded, class Category, class CommutativeRing, class Discard, class DivisionRing, class Eq, class EuclideanRing, class Field, class Functor, class Generic, class HeytingAlgebra, class Monad, class MonadAff, class MonadEffect, class MonadError, class MonadThrow, class Monoid, class Newtype, class Ord, class Ring, class Semigroup, class Semigroupoid, class Semiring, class Show, type (~>), Aff, Buffer, Docc, Effect, Either(..), Encoding(..), Error, Except, FilePath, HexString(..), Identity(..), Instant, License, List, Location, LogEnv, LogOptions, Manifest(..), ManifestIndex, Map, Maybe(..), Metadata(..), NonEmptyArray, OnlineStatus(..), Ordering(..), OutputFormat(..), PackageName, Range, Ref, Set, Sha256, Spago(..), StateT, Tuple(..), Unit, Version, Void, YamlDoc, absurd, add, and, ap, append, apply, ask, asks, between, bimap, bind, bottom, catchError, clamp, compare, comparing, compose, conj, const, degree, die, die', discard, disj, div, either, eq, except, flap, flip, foldMap, foldl, for, forWithIndex, for_, fromMaybe, fst, gcd, genericShow, hush, identity, ifM, indent, indent2, isJust, isLeft, isNothing, isPrefix, isRight, join, justOrDieWith, justOrDieWith', lcm, liftA1, liftAff, liftEffect, liftM1, lmap, local, logDebug, logError, logInfo, logSuccess, logWarn, map, max, maybe, mempty, min, mkTemp, mkTemp', mod, mul, negate, not, notEq, on, one, or, otherwise, output, parTraverseSpago, parallelise, parseJson, parseLenientVersion, parseUrl, parseYaml, partition, partitionEithers, partitionMap, printJson, printYaml, pure, recip, rightOrDieWith, rightOrDieWith', rmap, runSpago, shaToHex, show, snd, sub, toDoc, top, traverse, try, typoSuggestions, unit, unless, unlessM, unsafeFromJust, unsafeFromRight, unsafeLog, unsafeStringify, unsafeThrow, unwrap, void, when, whenM, withBackoff', withForwardSlashes, zero, (#), ($), ($>), (&&), (*), (*>), (+), (-), (..), (/), (/=), (/\), (:), (<), (<#>), (<$), (<$>), (<*), (<*>), (<<<), (<=), (<=<), (<>), (<@>), (<|>), (=<<), (==), (>), (>=), (>=>), (>>=), (>>>), (||)) as X | |||
There was a problem hiding this comment.
Can we rollback this line? It's just confusing to have this huge import like this
There was a problem hiding this comment.
Oh yeah, sorry, that's accidental, from IDE support.
fsoikin
force-pushed
the
init-spec-node
branch
from
da8a4fc
to
cce9904
Compare
|
I think this is a good change, but after all the updates to the tests the CI times have ballooned - they are now 2x slower than the current trunk. That's a bit of a deal breaker, so let's think about an alternative approach; the no-hassle one is to add some |
|
Yes, I agree, this became quite unmanageable. I was hoping it would literally just be changing the template, but it turns out all the tests depend on it, and it's quite a ball of yarn. I do like the idea of multiple templates. Other tools have similar things (e.g. dotnet) and they're very popular. But I don't think it is critical for the current milestone. So I guess we should just table this change. Or throw it away altogether. |
|
Yeah let's not move forward with this as is, and I agree with you that it's not critical for the current milestone. I have reopened #573 to track this effort. |
Description of the change
It occurred to me that, since we're recommending
spec-nodein the docs now, it would make sense to include it in thespago inittemplate. So the user doesn't have to jump through extra hoops.I understand this may not be 100% desirable because it introduced extra moving parts. Feel free to throw away. Just an idea.
Checklist:
[ ] Added some example of the new feature to theREADME