Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated foldMap1Default #147

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Drop deprecated foldMap1Default #147

merged 3 commits into from
Mar 17, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Drops deprecated foldMap1Default

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

🏓 @thomashoneyman

@thomashoneyman
Copy link
Member

You need to fix the import errors, but otherwise 👍

[1/1 UnusedImport] src/Data/Semigroup/Foldable.purs:32:1

  32  import Prim.TypeError (class Warn, Text)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  The import of Prim.TypeError is redundant

@thomashoneyman thomashoneyman merged commit d3b01d3 into purescript:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman