Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps Stackage LTS resolver #160

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Conversation

jkachmar
Copy link
Contributor

@jkachmar jkachmar commented Feb 7, 2020

This bumps psc-package to build with the latest Stackage LTS (lts-14.23 at the time of writing).

This should resolve #157 since lts-14.23 includes aeson-pretty-0.8.8, although I'm not able to reproduce this as I'm not on Windows.

In case someone else is interested in trying this out on Windows, here's a link to the purescript-book fork at a commit that should surface the same error as reported in #157:

https://github.com/dwhitney/purescript-book/blob/51ac437475ae8b72f2cf9291c32785af4f5ba394/exercises/chapter3

@jkachmar
Copy link
Contributor Author

jkachmar commented Feb 7, 2020

Oh right, there's an AppVeyor integration here. I suppose I could add a small test case that checks whether or not that particular psc-package.json fails if you'd like.

@justinwoo
Copy link
Collaborator

Supposedly this comes up in sharkdp/insect#219, but only for some users. Probably has something to do with what your git config is for handling newlines.

@justinwoo
Copy link
Collaborator

Remind me to try to merge this when this passes the build and all, which might take forever because toasters and Haskell are a match made in hell

@justinwoo justinwoo merged commit 01263f5 into purescript:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse packages.json: Error in $: not enough input. (solution proposed)
2 participants