Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish PR 17 - Fix Gzip example #36

Merged
merged 6 commits into from
Sep 27, 2021
Merged

Finish PR 17 - Fix Gzip example #36

merged 6 commits into from
Sep 27, 2021

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Sep 21, 2021

Description of the change

Finishes #17.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

matthewleon and others added 2 commits November 27, 2017 12:18
@JordanMartinez JordanMartinez mentioned this pull request Sep 22, 2021
@@ -0,0 +1,3762 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually commit these lockfiles. Could it be added to the .gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, it already is in the .gitignore file. I've dropped it from this PR.

@JordanMartinez JordanMartinez merged commit facc272 into master Sep 27, 2021
@JordanMartinez JordanMartinez deleted the finishGzipExample branch September 27, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants