Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.15.0 #46

Merged

Conversation

sigma-andex
Copy link
Contributor

Description of the change

Backlinking to purescript/purescript#4244

Migrates FFI to ES modules


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@sigma-andex sigma-andex marked this pull request as ready for review March 22, 2022 14:46
@sigma-andex
Copy link
Contributor Author

🏓 @JordanMartinez

Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for the function's arrow syntax.

@thomashoneyman
Copy link
Contributor

@JordanMartinez Personally, I don't mind the arrow syntax. We're only restrictive about that in the core libraries; Node can use arrow syntax if it wants IMO.

@JordanMartinez
Copy link
Contributor

@thomashoneyman Why was it decided that we would not use arrow syntax in core? Wouldn't that reason also apply here?

@thomashoneyman
Copy link
Contributor

@thomashoneyman Why was it decided that we would not use arrow syntax in core? Wouldn't that reason also apply here?

It's to do with library users not having to transpile their code in order to run it on old browsers like IE. The same compatibility concerns apply to Node, but Node has supported arrow syntax well before Node 12 (the oldest LTS version), so this particular one doesn't affect Node users.

@JordanMartinez JordanMartinez merged commit 4dcfd77 into purescript-node:master Mar 22, 2022
@JordanMartinez
Copy link
Contributor

@sigma-andex Looks like we forgot to update the changelog here.

@sigma-andex sigma-andex deleted the es-modules-libraries branch March 22, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants