-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.15.0 #46
Update to v0.15.0 #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for the function's arrow syntax.
@JordanMartinez Personally, I don't mind the arrow syntax. We're only restrictive about that in the core libraries; Node can use arrow syntax if it wants IMO. |
@thomashoneyman Why was it decided that we would not use arrow syntax in core? Wouldn't that reason also apply here? |
It's to do with library users not having to transpile their code in order to run it on old browsers like IE. The same compatibility concerns apply to Node, but Node has supported arrow syntax well before Node 12 (the oldest LTS version), so this particular one doesn't affect Node users. |
@sigma-andex Looks like we forgot to update the changelog here. |
Description of the change
Backlinking to purescript/purescript#4244
Migrates FFI to ES modules
Checklist: