Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ST for effects #24

Closed
matthewleon opened this issue Nov 5, 2017 · 2 comments
Closed

use ST for effects #24

matthewleon opened this issue Nov 5, 2017 · 2 comments

Comments

@matthewleon
Copy link
Contributor

Following Data.Array.ST's example, mutations could live in the ST monad. Then creation and reading would not require Eff. This would be a very big change to the library's philosophy.

Thoughts?
@hdgarrood
Copy link
Member

I think this is a good idea, definitely worth exploring. I think it might make sense to provide a new API inside this library, perhaps under the Node.Buffer.ST namespace, alongside the current API (hopefully we could do this in a non-breaking way). I think both approaches are useful in different scenarios, so I don't wouldn't want to replace the current API.

@hdgarrood hdgarrood mentioned this issue Dec 30, 2018
Merged
hdgarrood added a commit that referenced this issue Mar 10, 2019
@hdgarrood
Merge pull request #33 from Dretch/stbuffer-typeclass
7098df6 
Explore using ST for effects (issue #24)
@hdgarrood
Copy link
Member

Fixed by #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewleon @hdgarrood