Add initial version of node-buffer-blob

[sigma-andex]

First version of node-buffer-blob

[sigma-andex]

The node constructor uses a union type, accepting a list of blobs, a list of arraybuffers, a list of strings, ....
I have created constructor functions fromArrays, fromBlobs for the moment. Not sure if there is a better way to do it without depending on something like untagged-union..

[sigma-andex]

Apart from this, I think this initial pr is ready for review.

[sigma-andex]

🏓 @JordanMartinez

[JordanMartinez]

Overall looks good. But there are still a few changes to be made.

Could you clarify why you didn't do FFI for blob.type? Or implement Blob.from for the following?

• Array TypedArray
• Array DataView
• Array Blob

[JordanMartinez]

Could you drop the git+ part here?

[JordanMartinez]

There's no blob.type FFI?

[sigma-andex]

Fixed

[JordanMartinez]

Shouldn't there be newlines in the expected string? Otherwise, the Blob.Transparent part isn't being tested, right?

[sigma-andex]

Added newlines. Not sure though how this option should/could be tested

[JordanMartinez]

Also, I wonder if the singular versions of Blob.from (e.g. fromString) should be dropped. It's not too hard to go from fromString "foo" to fromStrings <<< Array.singleton or just fromStrings ["foo"]. Then there's less FFI to write.

But if calling blob.from([]) is problematic, then perhaps it should be NonEmptyArray a where a is one of those 5 types that Blob.from accepts.

[sigma-andex]

Also, I wonder if the singular versions of Blob.from (e.g. fromString) should be dropped. It's not too hard to go from fromString "foo" to fromStrings <<< Array.singleton or just fromStrings ["foo"]. Then there's less FFI to write.

But if calling blob.from([]) is problematic, then perhaps it should be NonEmptyArray a where a is one of those 5 types that Blob.from accepts.

Yeah that makes sense. I changed everything to NonEmptyArrays.

[JordanMartinez]

Could you clarify why you didn't implement Blob.from for the following types?

NonEmptyArray TypedArray
NonEmptyArray DataView
NonEmptyArray Blob

[sigma-andex]

Could you clarify why you didn't implement Blob.from for the following types?

Oh I just missed these, will add them

[sigma-andex]

Ok I added fromBlobs and fromDataView. I haven't yet figured out how the TypedArray works and at this point I would prefer to have that addressed in a subsequent PR if someone requires it.

[JordanMartinez]

Ok I added fromBlobs and fromDataView. I haven't yet figured out how the TypedArray works and at this point I would prefer to have that addressed in a subsequent PR if someone requires it.

I'm good with that.