Minifier-friendly references to properties #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd-yip
force-pushed
the
minifier-friendly
branch
from
0c7765d to
2e710dc
Compare
|
Thanks for the PR @sd-yip ! Please come and talk about it on the PureScript Discord contrib channel. https://discord.com/channels/864614189094928394/938253816862736405 |
natefaubion
reviewed
Apr 6, 2022
src/React.js
Outdated
| throw new Error("[purescript-react] Not a component property: " + prop); | ||
| function curry2(f) { | ||
| return f === undefined ? f : function (a, b) { | ||
| return f(a)(b) |
There was a problem hiding this comment.
I don't think these are correct. They are missing the () for invoking the effects (ie, it's not just a curry).
There was a problem hiding this comment.
I see. Previously, I applied the amount of arguments + 1 as the currying number for UNSAFE_componentWillReceiveProps and UNSAFE_componentWillUpdate, but not sure why I have missed them for the remaining.
Now the invocation and currying should be fixed. Please take another look.
natefaubion
approved these changes
Apr 8, 2022
6 tasks
thomashoneyman
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Dynamically matching property names in a switch is hard to detect and optimize. Currently, it breaks minifier outputs under aggressive minification settings. This PR modifies the corresponding part for easier usage with a minifier.
Checklist: