Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria and data props do not generate the correct result #70

Closed
ethul opened this issue Mar 13, 2016 · 0 comments
Closed

Aria and data props do not generate the correct result #70

ethul opened this issue Mar 13, 2016 · 0 comments
Assignees
@ethul
Labels
type: bug Something that should function correctly isn't.

Comments

@ethul
Copy link
Contributor

ethul commented Mar 13, 2016

The aria and data props generate JS objects keyed by aria and data, respectively.

However, the result should be of the form:

{ 'aria-<subprop key>': <subprop value> }
{ 'data-<subprop key>': <subprop value> }
@ethul ethul added the type: bug Something that should function correctly isn't. label Mar 13, 2016
@ethul ethul self-assigned this Mar 13, 2016
ethul added a commit that referenced this issue Mar 13, 2016
@ethul
Aria and data props now prefix sub-props
0b862a2 
Resolves #70
@ethul ethul mentioned this issue Mar 13, 2016
Merged
@ethul ethul closed this as completed in #71 Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethul ethul

Labels
type: bug Something that should function correctly isn't.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethul