-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Pass tests under macOS #340
ci: Pass tests under macOS #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Some changes to do and we should be good
@edouard-lopez I've updated the tests to use a dedicated container test for macOS and Linux, but I don't think it's possible to specify a particular version of Fish to install with Homebrew. Usually, only the latest versions are supported. Some applications like postgres do have multiple versions and some applications do have custom taps with multiple versions, but that does not seem to be the case for Fish. Maybe that could be fixed by someone a follow-up PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I introduced a regression with the code I suggested that added an extra end
on each block. Could you update and then rebase on master ?
There is an issue with |
The failure was due to error in the test file (not cleaning a mocked method), I will fix in #347 |
Related: Fixes #294
Description
This fixes the tests so macOS CI passes. There were two main issues:
set -U
not working on macOS (currently fish version 3.7)First contribution?
Check the 👍 Contribute section and the contributing guide.
Acceptance Checks
conf.d/pure.fish
;conf.d/pure.fish
;