Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iTerm shell integration #164

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Fix iTerm shell integration #164

merged 3 commits into from
Apr 11, 2019

Conversation

andreiborisov
Copy link
Collaborator

Fixes #116

@edouard-lopez
Copy link
Member

edouard-lopez commented Apr 11, 2019

Thanks,
could you add a tests/fish_mode_prompt.test.fish that assert:

@edouard-lopez edouard-lopez mentioned this pull request Apr 11, 2019
5 tasks
@andreiborisov andreiborisov force-pushed the iterm-shell-integration branch 3 times, most recently from e191590 to 0a0d524 Compare April 11, 2019 17:10
@andreiborisov
Copy link
Collaborator Author

@edouard-lopez I have no idea why tests are failing, can you look into that?

@edouard-lopez
Copy link
Member

@schrodincat

fish_mode_prompt doesn't print any so there is no string to compare,
but we can check the output has no length.

But I think there are problems with other tests.

@andreiborisov
Copy link
Collaborator Author

fish_mode_prompt doesn't print any so there is no string to compare, but we can check the output has no length

Yep, I came to the same conclusion.

@edouard-lopez edouard-lopez merged commit 5b487ca into master Apr 11, 2019
@edouard-lopez edouard-lopez deleted the iterm-shell-integration branch April 11, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants