Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer #127

Merged
merged 34 commits into from
Jan 11, 2019
Merged

Installer #127

merged 34 commits into from
Jan 11, 2019

Conversation

edouard-lopez
Copy link
Member

@edouard-lopez edouard-lopez commented Jan 11, 2019 •
edited
Loading

related: #81

  • update documentation:
    • revamp configuration section e5af49f
    • update feature list section 07951f2
  • installation method tests use internal docker image pure-on-fish.Dockerfile 6d5e85c
  • prefix tests description with their filename f79a505 9b7a361
  • fix busybox compatibility: use short form option (hostname, rm, gawk) 840b5aa 09e270d 4dbb2fe
  • isolate configuration tests 295b69b
docker run \
		--name run-pure-on-3.0.0 \
		--rm \
		--interactive \
		--tty \
		--volume=(pwd):/tmp/.pure/ \
		pure-on-fish-3.0.0

@edouard-lopez
update feature list section
07951f2
@edouard-lopez
revamp configuration section
e5af49f
@edouard-lopez
add task to 'dev-on' that mount local dev directory to container
87c4e98
@edouard-lopez
group install steps in dockerfile
1e60c33
@edouard-lopez
remove pure installation step, we already copy source manually
073cbcd
@edouard-lopez
use multi-stage docker container
de38396
@edouard-lopez
chown files copied from previous stage in docker
8f10c40
@edouard-lopez
use short form option to be compatible with busybox in docker
840b5aa
@edouard-lopez
rename test file related to tooling as pure_tools_*
4fc06f8
@edouard-lopez
prefix test from pure_tools_installer.test.fish
f79a505
@edouard-lopez
remove previous installer dockerfile and related
36706ca
@edouard-lopez
add ENTRYPOINT and default CMD
908bb73
@edouard-lopez
update command to run tests
33a77c6
@edouard-lopez
prefix tests from tests/pure_tools_installer.test.fish
18634da
@edouard-lopez
rename file with typo
431f24e
@edouard-lopez
fix version-compare for busybox (
09e270d 
Available `sort` version doesn't support ` --check=silent --version-sort`

See fish-shell/fish-shell#4419 (comment)
@edouard-lopez
force redefinition of configuration variable when testing them
295b69b
@edouard-lopez
restore fish_default_key_bindings
a0737a5
@edouard-lopez
prefix test description with tested filename
9b7a361
@edouard-lopez
clean-up global variable after test
0075154
@edouard-lopez
remove typo (comma at the end of curly braces)
c060f7f
@edouard-lopez
switch to internal docker image
f438db8
@edouard-lopez
test fish_prompt output for manual install
03a2fe6
@edouard-lopez
fix manual install, source config file
854f772 
closes #81
@edouard-lopez
chown to docker user the whole ~/.config/ directory
4561fbc
@edouard-lopez
rename installation-methods.test.fish
b3ab425
@edouard-lopez
extract installation method tests so we can run them in container
6d5e85c
@edouard-lopez edouard-lopez added 🐛 bug something that doesn't works as expected 🚀 enhancement performance, UX or maintainability fish-3.x labels Jan 11, 2019
@edouard-lopez edouard-lopez added this to the v2.0.0 milestone Jan 11, 2019
@edouard-lopez
rely on CMD directive to run test-on target
94c5751
@edouard-lopez
use short form option to be compatible with busybox
1c28f02
@edouard-lopez
install gawk in docker image for fisher
4dbb2fe
@edouard-lopez
add default/usage target
34d1c17
@edouard-lopez
improve test description for installation method
02ef1a8
@edouard-lopez
rename makefile target consistently
a00f23f 
make build-pure-on FISH_VERSION=3.0.0   # build container
make test-pure-on  FISH_VERSION=3.0.0   # run tests
make dev-pure-on   FISH_VERSION=3.0.0   # dev in container
@edouard-lopez
rollback on multi-stage docker to simplify
1156142 
Install of `gwak` was required in second stage requiring to:
* juggle with USER
* COPY --from various directory
@edouard-lopez edouard-lopez merged commit 4c5acdd into master Jan 11, 2019
@edouard-lopez edouard-lopez deleted the installer branch January 11, 2019 22:57
This was referenced Jan 12, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 bug something that doesn't works as expected 🚀 enhancement performance, UX or maintainability
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@edouard-lopez