Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More customizations #103

Merged
merged 17 commits into from
Jan 8, 2019
Merged

More customizations #103

merged 17 commits into from
Jan 8, 2019

Conversation

andreiborisov
Copy link
Collaborator

@andreiborisov andreiborisov commented Dec 14, 2018 •
edited
Loading

Rebased and reworked based on #70

@andreiborisov andreiborisov mentioned this pull request Dec 14, 2018
Closed
rafaelrinaldi
rafaelrinaldi approved these changes Dec 18, 2018
View reviewed changes
Copy link
Collaborator

@rafaelrinaldi rafaelrinaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work Andrei. Looks great to me!

Thanks for this and all the effort you put into this project lately. This is much appreciated.

@rafaelrinaldi

This comment has been minimized.

Sign in to view
@andreiborisov

This comment has been minimized.

Sign in to view
@edouard-lopez
Copy link
Member

Following the discussion, I submitted PR #106 to update CONTRIBUTING.md

@andreiborisov
Copy link
Collaborator Author

Rebase and necessary fixes are in the work

@andreiborisov
Copy link
Collaborator Author

andreiborisov commented Jan 3, 2019 •
edited
Loading

Everything is looking good

sodisdocs and others added 12 commits January 5, 2019 20:59
@sodisdocs
Change prompt symbol default color to magenta
a6264be
@boyeln @sodisdocs
update screenshot to show the new prompt color
97ce599
@sodisdocs
Give every prompt attribute a configurable color variable
5d28109
@boyeln @sodisdocs
update readme to show the new color variables
8a5dc28
@sodisdocs
Arrange colors in alphabetical order
04e031a
@sodisdocs
Rename functions and variables for consistency
66864be
@sodisdocs
Use terminal color for gray by default
0aa1ae6 
There is a possiblity that text can get indistinguishable of background when it uses hardcoded color value.

Use brblack variable for gray color instead in order to delegate this problem to terminal color scheme or theme plugins and insure that it won’t collide with background.
@sodisdocs
Use idiomatic fish form of test command
f1961d6
@sodisdocs
Use long form of “local” option with set
44d4f71
@sodisdocs
Fix readme git arrows symbol names and comments
6109a6e
@sodisdocs
Remove unnecessary files
9752f60
@sodisdocs
Fix tests after renaming and adding more options
7b3700c
boyeln
boyeln approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@boyeln boyeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@edouard-lopez edouard-lopez merged commit f3a5d12 into pure-fish:master Jan 8, 2019
@edouard-lopez edouard-lopez mentioned this pull request Jan 8, 2019
Closed
@andreiborisov andreiborisov deleted the more-customizations branch January 8, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgebucaran jorgebucaran jorgebucaran left review comments

@edouard-lopez edouard-lopez edouard-lopez left review comments

@rafaelrinaldi rafaelrinaldi rafaelrinaldi approved these changes

@boyeln boyeln boyeln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andreiborisov @rafaelrinaldi @edouard-lopez @jorgebucaran @boyeln @sodisdocs