Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pg_query 0.9.1, adds PostgreSQL 9.5 syntax support #6

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Update to pg_query 0.9.1, adds PostgreSQL 9.5 syntax support #6

merged 1 commit into from
Apr 21, 2016

Conversation

lfittl
Copy link
Contributor

@lfittl lfittl commented Apr 21, 2016

First of all, thanks for building this on top of pg_query! :)

I saw you are using an older version of pg_query right now (0.5), and I recently released 0.9.0 - which amongst other improvements is based on PostgreSQL 9.5 - which means sqlint will also support UPSERT once you upgrade.

Tests all pass, I had to fix a minor detail with error messages (they are more verbose now), but output should be identical for the end user.

@lfittl
Copy link
Contributor Author

lfittl commented Apr 21, 2016

@purcell I see the tests are unhappy about the missing 1.9 support (pganalyze/pg_query#44) - I actually have a fix for this in the pipeline, I'll try to release a new version that supports 1.9 today and update the PR.

@purcell
Copy link
Owner

purcell commented Apr 21, 2016

Awesome, thanks.

@purcell
Copy link
Owner

purcell commented Apr 21, 2016

(And thanks for pg_query!)

@lfittl lfittl changed the title Update to pg_query 0.9.0, adds PostgreSQL 9.5 syntax support Update to pg_query 0.9.1, adds PostgreSQL 9.5 syntax support Apr 21, 2016
@lfittl
Copy link
Contributor Author

lfittl commented Apr 21, 2016

@purcell 0.9.1 released - tests are green now 🎉

@purcell purcell merged commit 96ddd2f into purcell:master Apr 21, 2016
@purcell
Copy link
Owner

purcell commented Apr 21, 2016

Yay, thanks so much for this.

@purcell
Copy link
Owner

purcell commented Apr 21, 2016

New gem version 0.1.4 pushed. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants