Prefer rx for regexp

purcell · Nov 10, 2023 · c541e67 · c541e67
1 parent 5eba825
commit c541e67
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/package-lint.el b/package-lint.el
@@ -181,8 +181,13 @@ symbol such as `variable-added'.")
         (with-temp-buffer
           (insert-file-contents el-path)
           (goto-char (point-min))
-          ;; TODO convert to rx
-          (while (search-forward-regexp "^(compat-\\(defun\\|defmacro\\|\\defvar\\) +\\_<\\(.*?\\)\\_>" nil t)
+          (while (search-forward-regexp (rx line-start
+                                            "(compat-" (group (or "defun" "defmacro" "defvar"))
+                                            (+ space)
+                                            symbol-start
+                                            (group (+? any))
+                                            symbol-end)
+                                        nil t)
             (pcase (match-string 1)
               ("defvar" (push (intern (match-string 2)) symbols))
               ((or "defun" "defmacro") (push (intern (match-string 2)) functions)))))))