(QENG-1906) Add spec tests for Janitor #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,72 @@ | |||
| require 'rspec' | |||
| require 'vmpooler' | |||
There was a problem hiding this comment.
You should require 'spec_helper' here instead
colinPL
force-pushed
the
qeng_1906_janitor
branch
from
0efed65 to
008d0e4
Compare
Add spec tests to verify Janitor deletes stale vms correctly. This required a small refactor of Janitor to move the logic out of the for loop.
colinPL
force-pushed
the
qeng_1906_janitor
branch
from
008d0e4 to
d0275f5
Compare
|
👍 |
sschneid
added a commit
that referenced
this pull request
Mar 31, 2015
(QENG-1906) Add spec tests for Janitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for Janitor, verifying it deletes stale VMs.
NOTE: THIS IS DEPENDENT ON PR #77