/summary per-pool metrics #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is deployed on vmpooler-dev. Verification of my maths is probably needed. |
| @@ -240,13 +270,25 @@ def validate_date_str(date_str) | |||
| result[task][:duration][:total] += daily[task][:duration][:total] | |||
|
|
|||
| if result[task][:count][:total] > 0 | |||
There was a problem hiding this comment.
This block should be outside the loop so that the total duration average is only calculated once, not altered each day.
sschneid
force-pushed
the
per_pool_summary_metrics
branch
from
1866144 to
270f586
Compare
This commit also consolidates the 'get_boot_metrics' and 'get_clone_metrics' methods into a single parameterized 'get_task_metrics' method.
sschneid
force-pushed
the
per_pool_summary_metrics
branch
from
270f586 to
d1e4acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also consolidates the 'get_boot_metrics' and
'get_clone_metrics' methods into a single parameterized
'get_task_metrics' method.