(DIO-2621) Make LDAP encryption configurable #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genebean
force-pushed
the
fix_ldap_auth
branch
10 times, most recently
from
0c54fb9 to
91014a3
Compare
mattkirby
approved these changes
Sep 14, 2021
genebean
force-pushed
the
fix_ldap_auth
branch
2 times, most recently
from
ffaa8ef to
c95116d
Compare
Prior to this, the encryption settings for LDAP auth were hard coded to start_tls on port 389 with TLSv1. These are still the defaults, as insecure as they are, so as to not break existing users. This change facilitates replacing the defaults so that simple_tls over port 636 via TLS1.2 can be used.
genebean
force-pushed
the
fix_ldap_auth
branch
from
c95116d to
5cd7658
Compare
|
Deployed to test and validated that using the config below allows for successful token retrieval: :auth:
provider: 'ldap'
:ldap:
host: 'ldap.example.com'
port: 636
encryption:
:method: :simple_tls
:tls_options: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the encryption settings for LDAP auth were hard coded to start_tls on port 389 with TLSv1. These are still the defaults, as insecure as they are, so as to not break existing users. This change facilitates replacing the defaults so that simple_tls over port 636 via TLS1.2 can be used.