Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DIO-1059) Optionally add snapshot tuning params at clone time #419

Merged
merged 1 commit into from
Oct 16, 2020
Merged

(DIO-1059) Optionally add snapshot tuning params at clone time #419

merged 1 commit into from
Oct 16, 2020

Conversation

suckatrash
Copy link
Contributor

@suckatrash suckatrash commented Oct 13, 2020 •
edited
Loading

I've tested this locally and it appears to put the setting in the VMs vmx file at clone time

cat thin-precipice.vmx | grep mainM
mainMem.ioBlockPages = "2048"
mainMem.iowait = "0"

Tested by adding the following last two keys to the pool definition:

:pools:
  - name: 'erik-testing'
    snapshot_mainMem_ioBlockPages: '2048'
    snapshot_mainMem_iowait: '0'

@suckatrash suckatrash force-pushed the dio-1059 branch 5 times, most recently from 82782fb to c5e7d01 Compare October 16, 2020 22:06
@suckatrash suckatrash marked this pull request as ready for review October 16, 2020 22:06
@suckatrash suckatrash requested a review from a team as a code owner October 16, 2020 22:06
rooneyshuman
rooneyshuman reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@rooneyshuman rooneyshuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small spelling error and should squash commits - otherwise, worked great for me!

spec/unit/providers/vsphere_spec.rb Outdated Show resolved Hide resolved
@rooneyshuman rooneyshuman merged commit 217bdd7 into master Oct 16, 2020
@suckatrash suckatrash deleted the dio-1059 branch October 16, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooneyshuman rooneyshuman rooneyshuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suckatrash @rooneyshuman