(POOLER-166) Check for stale dns records #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbeaulie
force-pushed
the
pooler_166_on_master
branch
2 times, most recently
from
3413486 to
6304743
Compare
rooneyshuman
approved these changes
May 29, 2020
mattkirby
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we checked that the new vm name would not conflict with an existing vm already running and under the vmpooler management in redis.
We now also check if a DNS query returns an existing IP, which could happen if there are stale DNS record (or some other process registered the vm name already, like another vmpooler?). In that case we skip that name and try again.