Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rake requirement from ~> 12.3 to >= 12.3, < 14.0 #369

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rake to permit the latest version.

Changelog

Sourced from rake's changelog.

=== 13.0.1

==== Bug fixes

  • Fixed bug: Reenabled task raises previous exception on second invokation Pull Request #271 by thorsteneckel
  • Fix an incorrectly resolved arg pattern Pull Request #327 by mjbellantoni

=== 13.0.0

==== Enhancements

  • Follows recent changes on keyword arguments in ruby 2.7. Pull Request #326 by nobu
  • Make PackageTask be able to omit parent directory while packing files Pull Request #310 by tonytonyjan
  • Add order only dependency Pull Request #269 by take-cheeze

==== Compatibility changes

  • Drop old ruby versions(< 2.2)

=== 12.3.3

==== Bug fixes

  • Use the application's name in error message if a task is not found. Pull Request #303 by tmatilai

==== Enhancements:

  • Use File.open explicitly.

=== 12.3.2

==== Bug fixes

  • Fixed test fails caused by 2.6 warnings. Pull Request #297 by hsbt

==== Enhancements:

  • Rdoc improvements. Pull Request #293 by colby-swandale
  • Improve multitask performance. Pull Request #273 by jsm
  • Add alias prereqs. Pull Request #268 by take-cheeze
... (truncated)
Commits
  • c8251e2 Bump version to 13.0.1
  • 8edd860 Fixed build failure of the latest GitHub Actions
  • b6e2a66 Merge pull request #271 from thorsteneckel/bugfix-reenable_invocation_exception
  • 985abff Merge pull request #327 from mjbellantoni/mjb-order-only-arg-fix
  • 4a90acb Merge pull request #329 from jeremyevans/skip-taint-test-on-2.7
  • 4dc6282 Skip a taint test on Ruby 2.7
  • a08b697 Merge pull request #328 from orien/gem-metadata
  • c3953d4 Add project metadata to the gemspec
  • 46a8f7c Update comments to reflect the current state
  • 00aacdc Fix an incorrectly resolved arg pattern
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v12.3.0...v13.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot requested a review from a team as a code owner March 17, 2020 19:33
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Mar 17, 2020
vmpooler.gemspec Outdated Show resolved Hide resolved
Copy link
Contributor

@highb highb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There, consistency++

@highb
Copy link
Contributor

highb commented Mar 18, 2020

Looks like this spec is failing (sometimes?), I'll take a look at what might be doing on.

  1) Pool Manager #repopulate_pool_vms when number of VMs is less than the pool size log a message if a cloning error occurs
     Failure/Error: expect(logger).to receive(:log).with("s", "[!] [#{pool}] clone failed during check_pool with an error: MockError")
     
       (#<MockLogger:0x23696ffb>).log("s", "[!] [pool1] clone failed during check_pool with an error: MockError")
           expected: 1 time with arguments: ("s", "[!] [pool1] clone failed during check_pool with an error: MockError")
           received: 3 times with arguments: ("s", "[!] [pool1] clone failed during check_pool with an error: MockError")
     # ./spec/unit/pool_manager_spec.rb:3715:in `block in <main>'
Finished in 21.18 seconds (files took 4.17 seconds to load)
897 examples, 1 failure, 2 pending
Failed examples:
rspec ./spec/unit/pool_manager_spec.rb:3711 # Pool Manager #repopulate_pool_vms when number of VMs is less than the pool size log a message if a cloning error occurs

@highb
Copy link
Contributor

highb commented Mar 18, 2020

Oh, I think one of the "safe" rubocop corrections may not have been totally safe. It seems the corrector generally assumes that a rescue with no specified type should rescue StandardError whereas I think the general convention in our code, and in Ruby in general, is for a raise to default to RuntimeError. Because of this mismatch, I think we were getting a few odd spec issues, not to mention catching StandardError still catches a lot of things that probably shouldn't be caught? 2951900#diff-e39443f7a104f34a86d3e91b565c6ec8R493

@highb
Copy link
Contributor

highb commented Mar 18, 2020

Because I can never keep these things straight in my head, here's a chart for my own reference (and anyone else's):
image

@highb
Copy link
Contributor

highb commented Mar 18, 2020

Yeah, the spec issue goes away on re-run. Fun.

@highb highb merged commit 04a3c44 into master Mar 18, 2020
@dependabot-preview dependabot-preview bot deleted the 16c0dependabot/bundler/rake-gte-12.3-and-lt-14.0 branch March 18, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants