(POOLER-40) Do not return folders with get_pool_vms #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates get_pool_vms to only return if the object is a VirtualMachine. Without this change a folder wtihin a VM target folder can be discovered and destroyed as though it were a VM.
sbeaulie
approved these changes
Jul 4, 2018
sbeaulie
reviewed
Jul 4, 2018
| end | ||
|
|
||
| it 'should return the vms without the folder' do | ||
| result = subject.vms_in_pool(poolname) |
There was a problem hiding this comment.
that looks good, do you want it to also return VMs inside the folder 'pool2' or is it supposed to skip these?
There was a problem hiding this comment.
No, it's supposed to skip those and just evaluate the objects that are VMs in the base folder object. Previously it would treat the folder as though it was a VM and try to discover and destroy it.
There was a problem hiding this comment.
Yes I've seen that before. I wonder why we would have subfolders though
mchllweeks
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates get_pool_vms to only return if the object is a VirtualMachine. Without this change a folder wtihin a VM target folder can be discovered and destroyed as though it were a VM.