Reduce object lookups for finding folders #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces object lookups used for get_vm. Without this change get_vm looks up the VM folder, which is already used and known to find the vm with find_vm.
This commit replaces find_folder to use information already known about folders to determine their location and quickly fail when it does not exist without traversing the hierarchy. Without this change find_folder is very inneficient and can take a long time to return depending on how deep in the folder tree the folder exists.
This commit renames find_folder to find_vm_folder to clarify its intent to retrieve folders from the VM hierarchy. Without this change find_folder implies it may find folders that are not within the VM hierarchy.
|
This will resolve #204 . |
Dakta
reviewed
Jun 29, 2018
lib/vmpooler/providers/vsphere.rb
Outdated
| @@ -365,15 +353,22 @@ def get_target_datacenter_from_config(pool_name) | |||
| nil | |||
| end | |||
|
|
|||
| def generate_vm_hash(vm_object, template_name, pool_name) | |||
| hash = { 'name' => nil, 'hostname' => nil, 'template' => nil, 'poolname' => nil, 'boottime' => nil, 'powerstate' => nil } | |||
| def generate_vm_hash(vm_object, pool_name) | |||
There was a problem hiding this comment.
This seems like a good opportunity to add documentation to this method.
There was a problem hiding this comment.
I added some brief documentation to this method. Let me know if you think it doesn't cover what you were hoping to see, it's pretty brief.
mchllweeks
approved these changes
Jun 29, 2018
smcelmurry
approved these changes
Jul 3, 2018
Dakta
approved these changes
Jul 9, 2018
lib/vmpooler/providers/vsphere.rb
Outdated
| @@ -365,15 +353,22 @@ def get_target_datacenter_from_config(pool_name) | |||
| nil | |||
| end | |||
|
|
|||
| def generate_vm_hash(vm_object, template_name, pool_name) | |||
| hash = { 'name' => nil, 'hostname' => nil, 'template' => nil, 'poolname' => nil, 'boottime' => nil, 'powerstate' => nil } | |||
| def generate_vm_hash(vm_object, pool_name) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits reduce the number of objects looked up when finding VM folders. Additionally, object lookup methods that scan for a folder with a matching name are removed in favor of searchIndex with FindByInventoryPath. Without this change the time it takes to find VM folders is much longer and more resource intensive.