(POOLER-31) Expire redis vm key when clone fails #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates pool_manager to expire a redis VM key when a clone fails. Without this change VMs that fail to clone have their metadata left forever.
Dakta
reviewed
Jun 29, 2018
| @@ -245,7 +245,9 @@ def _clone_vm(pool, provider) | |||
|
|
|||
| $metrics.timing("clone.#{pool_name}", finish) | |||
| rescue => _err | |||
| $redis.srem('vmpooler__pending__' + pool_name, new_vmname) | |||
| $redis.srem("vmpooler__pending__#{pool_name}", new_vmname) | |||
| expiration_ttl = $config[:redis]['data_ttl'].to_i * 60 * 60 | |||
There was a problem hiding this comment.
It looks like redis is taking seconds for this value, so data_ttl is in units of hours? Can this be documented somewhere?
There was a problem hiding this comment.
It looks like there is a mention of this in the example configuration file https://github.com/puppetlabs/vmpooler/blob/master/vmpooler.yaml.example#L180 .
mchllweeks
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates pool_manager to expire a redis VM key when a clone fails. Without this change VMs that fail to clone have their metadata left forever.