(POOLER-92) Add the alias information in the API status page for each… #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pool Before this change if a pool had an alias configured, the information would not be made public in the API. This commit adds the alias key in the pool object for each pool if configured. The alias key can be abscent, a string or an one or multiple array of strings. The value of the alias is copied from the configuration and can represent another name for the pool, or another configured pool.
glennsarti
reviewed
Oct 18, 2017
vmpooler.yaml.aliasedpools
Outdated
| @@ -0,0 +1,74 @@ | |||
| --- | |||
There was a problem hiding this comment.
Is this test fixture file in the right location? i.e. the root of the project? Should it be under /spec/?
There was a problem hiding this comment.
It's not used by the spec tests, in fact I have not seen any .yaml file in the spec directory. I want that example dummy config file in the repo to share that file with my team members working on integrating this new information into the ABS scheduler. I think the directory ex would be better for this?
mattkirby
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pool
Before this change if a pool had an alias configured, the information would not be
made public in the API. This commit adds the alias key in the pool object for each
pool if configured. The alias key can be absent, a string or an one or multiple
array of strings. The value of the alias is copied from the configuration and can
represent another name for the pool, or another configured pool.