(GH-226) Respond quickly to VMs being consumed #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in commit 9b0e55f the looping period was changed from a static number to a dynamic one depending on load, however this meant that the operation to refill a pool was slowed down somewhat. While not a problem under normal loads, when a pool was quickly consumed, the pool manager may not respond quickly enough to refill the pool. This commit: - Changes the sleep method, to us a helper sleep method that will wakeup periodically and evaluate other wakeup events. This could be used later to exist sleep loops when pooler is shutting down to stop blocking threads - By default the wakeup_period is set to the minimum pool check loop time, thus emulating the behaviour prior to commit 9b0e55f - Adds tests for the behaviour
glennsarti
force-pushed
the
make-check-pool-more-responsive
branch
from
359b6b5 to
f209c2b
Compare
glennsarti
changed the title
|
@mattkirby ping, when you get a sec |
Do we need to pin the version of the redis gem? |
|
Doh...looks like we do :-( I'll add this to the this PR |
Nokogiri and Redis gems have had recent releases which are not compatible with older ruby versions. This commit modifies the Gemfile to get the latest of each of these gems on modern ruby versions and pin to the older gem versions for older ruby engines.
glennsarti
force-pushed
the
make-check-pool-more-responsive
branch
from
70aa90b to
0840e11
Compare
|
@shrug Done. Nokogiri needed some work too. |
|
Thanks @mattkirby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in commit 9b0e55f the looping period was changed from a static
number to a dynamic one depending on load, however this meant that the operation
to refill a pool was slowed down somewhat. While not a problem under normal
loads, when a pool was quickly consumed, the pool manager may not respond
quickly enough to refill the pool. This commit:
periodically and evaluate other wakeup events. This could be used later to
exit sleep loops when pooler is shutting down to stop blocking threads
emulating the behaviour prior to commit 9b0e55f