Fix rubocop #232
Merged
Fix rubocop #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the many rubocop offenses. Also modifies the rubocop settings: - Set max method params higher than the default of 5 - Ignore Style/GuardClause. In some cases it's eaiser to read without the guard - Renamed a cop
Sometimes this test would fail if the computer running the tests was under a bit of load. This commit changes the expected output to be up to 1.99 seconds instead of the previous 0.99 seconds.
glennsarti
commented
Jul 18, 2017
| @@ -462,7 +460,7 @@ def _check_snapshot_queue | |||
|
|
|||
| def migration_limit(migration_limit) | |||
| # Returns migration_limit setting when enabled | |||
| return false if migration_limit == 0 || ! migration_limit | |||
| return false if migration_limit == 0 || !migration_limit # rubocop:disable Style/NumericPredicate | |||
There was a problem hiding this comment.
Disable the cop here because migration limit can come in as an Integer OR boolean type
underscorgan
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of rubocop fixes. Only files left are in the api, but we don't have enough tests in that area to bravely fix them.