Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vagrant setup and fixed the Dockerfile so it actually works #222

Merged
merged 4 commits into from
Jun 20, 2017

Conversation

genebean
Copy link
Contributor

No description provided.

genebean added 2 commits June 12, 2017 13:27
Set to use a newer JRuby
Added an environment variable for the log file location
Changed entrypoint to cmd to add flexibility
Added missing trailing slash to copy command path
@genebean genebean force-pushed the docker-in-vagrant branch from 21da63c to d5c71f4 Compare June 12, 2017 22:19
@stahnma
Copy link

stahnma commented Jun 13, 2017

Why would we I want docker in vagrant vs just using docker? (I simply don't understand).

@genebean
Copy link
Contributor Author

@stahnma I don't like the mess Docker can leave on my laptop so I generally run all my Docker stuff inside a VM. When I am finished or "think" I am finished with something Docker-related I will generally blow away the vm and bring it back up to see if I got it right.

@stahnma
Copy link

stahnma commented Jun 13, 2017

Ha, I feel the same way about Vagrant. :)

@genebean
Copy link
Contributor Author

LOL. At least to clean up vagrant all I have to do is delete a folder or two... I always end up going back to Google to remember how to clean up after Docker.

@stahnma
Copy link

stahnma commented Jun 13, 2017

I always just had vbox crash my laptop. Either way, carry on.

Copy link
Contributor

@heathseals heathseals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of layers of abstraction here, but it works. 👍

@sbeaulie
Copy link
Contributor

hey why not!?

@sbeaulie sbeaulie merged commit c0913ed into master Jun 20, 2017
WORKDIR /var/lib/vmpooler

ADD Gemfile* /var/lib/vmpooler
ADD Gemfile* /var/lib/vmpooler/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this * here failed for me when I had a Gemfile + a Gemfile.lock
I don't know why there is a * wildcard here?

@genebean genebean deleted the docker-in-vagrant branch July 5, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants