-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Vagrant setup and fixed the Dockerfile so it actually works #222
Conversation
Set to use a newer JRuby Added an environment variable for the log file location Changed entrypoint to cmd to add flexibility Added missing trailing slash to copy command path
21da63c
to
d5c71f4
Compare
d5c71f4
to
a7274f3
Compare
Why would we I want docker in vagrant vs just using docker? (I simply don't understand). |
@stahnma I don't like the mess Docker can leave on my laptop so I generally run all my Docker stuff inside a VM. When I am finished or "think" I am finished with something Docker-related I will generally blow away the vm and bring it back up to see if I got it right. |
Ha, I feel the same way about Vagrant. :) |
LOL. At least to clean up vagrant all I have to do is delete a folder or two... I always end up going back to Google to remember how to clean up after Docker. |
I always just had vbox crash my laptop. Either way, carry on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of layers of abstraction here, but it works. 👍
hey why not!? |
WORKDIR /var/lib/vmpooler | ||
|
||
ADD Gemfile* /var/lib/vmpooler | ||
ADD Gemfile* /var/lib/vmpooler/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this * here failed for me when I had a Gemfile + a Gemfile.lock
I don't know why there is a * wildcard here?
No description provided.