Update usage of global variablesin vsphere_helper #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
approved these changes
Mar 6, 2017
|
Would it be better to submit this as a PR to #196 so there's a place for them? |
|
Um.. Not sure. My intent in 196 was to document the existing behaviour only and then we can submit later PRs to modify the behaviour. However I'm not averse to this PR being merged prior to 196. All it's doing is just shifting when the work gets done :-) |
|
I think this needs a rebase |
This commit updates usage of global variables in vsphere_helper to be instance variables. They do not need to be global variables as brought up in issue puppetlabs#194. Without this change we are setting global variables when they are not needed.
glennsarti
force-pushed
the
helper_no_global_vars
branch
from
a84a498 to
80c01eb
Compare
|
@shrug Rebased on @mattkirby 's behalf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates usage of global variables in vsphere_helper to be instance variables. They do not need to be global variables as brought up in issue #194. Without this change we are setting global variables when they are not needed.